Page MenuHomePhabricator

ORES returns 200 for timed out scores
Open, MediumPublic

Description

Continuing from T196076: ORESFetchScoreJob fails quite a lot For example https://ores.wikimedia.org/v3/scores/enwiki/848321115 gives time out for all models but still the response is 200. Which is not correct and should respond either with 504 or 503. Fun note to consider: What if one model times out and one doesn't?

Event Timeline

Ladsgroup created this task.Jul 4 2018, 9:15 PM
Restricted Application added a project: Machine Learning Platform. · View Herald TranscriptJul 4 2018, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mobrovac added a subscriber: mobrovac.

What if one model times out and one doesn't?

Arguably it should still return a 50x looking from the perspective that the client did not receive the information it asked for (results for both models).

Harej triaged this task as Medium priority.Aug 3 2018, 6:54 PM