Maniphest T198826

Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode
Closed, ResolvedPublic
Actions

Description

Edit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Sandbox&oldid=381685
Select [2].
Make some minor change, eg. change "Source date" from 1981 to 1980.
Press "Apply changes".

Console error:

Uncaught TypeError: Cannot read property 'element' of null
    at VeCeMWTransclusionInlineNode.ve.ce.View.initialize
    at VeCeMWTransclusionInlineNode.ve.ce.LeafNode.initialize
    at VeCeMWTransclusionInlineNode.ve.ce.GeneratedContentNode.render
    at VeCeMWTransclusionInlineNode.ve.ce.MWTransclusionNode.render
    at VeCeMWTransclusionInlineNode.ve.ce.GeneratedContentNode.doneGenerating
    at load.php?debug=false&lang=en&modules=ext.CodeMirror.lib|ext.visualEditor.core...
    at fire (...jquery)
    at Object.fireWith [as resolveWith] (...jquery)
    at Object.deferred.(/w/anonymous function) [as resolve] (...jquery)
    at VeCeMWTransclusionInlineNode.ve.ce.MWTransclusionNode.onParseSuccess (<anonymous>)

Happens consistently in production (en.wikipedia.org; 1.32.0-wmf.10) and reproducible still on latest master in Beta Cluster.

Observed in latest Chrome on macOS while logged-in.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (bbe825690)	mediawiki/extensions/VisualEditor	master	+2 -1
	Fix cleanup of PreviewElement after render	VisualEditor/VisualEditor	master	+26 -19

Customize query in gerrit

Related Objects

Mentioned In: T197845: CX2: Uncaught TypeError: Cannot read property 'element' of null
Mentioned Here: rGVEDbbe825690861: Merge "Create basic tests for PreviewElement"

Event Timeline

Krinkle created this task.Jul 5 2018, 12:13 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 5 2018, 12:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Esanders claimed this task.Jul 5 2018, 2:16 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 443981 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix cleanup of PreviewElement after render

https://gerrit.wikimedia.org/r/443981

gerritbot added a project: Patch-For-Review.Jul 5 2018, 2:45 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jul 5 2018, 2:51 PM

Change 443981 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix cleanup of PreviewElement after render

https://gerrit.wikimedia.org/r/443981

Esanders mentioned this in T197845: CX2: Uncaught TypeError: Cannot read property 'element' of null.Jul 5 2018, 4:08 PM

• Petar.petkovic removed a project: Patch-For-Review.Jul 5 2018, 4:48 PM

Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.Jul 5 2018, 10:48 PM

Change 444139 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)

https://gerrit.wikimedia.org/r/444139

gerritbot added a project: Patch-For-Review.Jul 5 2018, 11:09 PM

Change 444139 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbe825690)

https://gerrit.wikimedia.org/r/444139

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed Patch-For-Review.Jul 6 2018, 6:19 PM

DLynch merged a task: T199043: Uncaught type errors inserting citations with citoid, and adding or removing unused parameters to template inside ref in VE in production (but the changes are successful).Jul 9 2018, 5:19 PM

DLynch added subscribers: Mvolz, • Deskana.

Ryasmeen added a project: Verified.Jul 11 2018, 10:31 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Jul 19 2018, 9:59 AM

• Deskana triaged this task as Medium priority.

Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNodeClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode
Closed, ResolvedPublic
Actions