Page MenuHomePhabricator

Explore feed customization: Collapsed feed cards
Closed, ResolvedPublic

Description

Proposed Designs

Single card hiddenCard type hidden from action sheet
102_Feed customization.png (1×750 px, 624 KB)
103_Feed customization.png (1×750 px, 629 KB)
Zeplin: https://zpl.io/VDDG5dwZeplin: https://zpl.io/2954BEe

Design details
The placeholder cards should only appear once per card type and should be shown in place until a refresh of the feed.

Near-term Designs

Single card hiddenCard type hidden from action sheet
Near term - Card hidden.png (1×750 px, 186 KB)
Near term - all of card type hidden.png (1×750 px, 188 KB)
Zeplin: https://zpl.io/a3qLQpAZeplin: https://zpl.io/brN4GJ5

Design details
Popover should last for the same amount of time as the add to reading list popover

Event Timeline

NHarateh_WMF lowered the priority of this task from High to Medium.Jul 9 2018, 6:42 PM

This would be easier to do as a popover as a first pass, either similar to the error popover from the top, or the reading list popover from the bottom.

I think to properly implement this as designed, would add a property to WMFContentGroup that's something like undoType that would have an enum that dictated that card would be displayed as an undo card and what action would be taken when the user taps undo.

@cmadeo how long does the undo card stay visible?

Per the meeting, okay to do a popover version for 6.0

I'll mock up some designs after my afternoon meeting.

Also for the future, I imagined the undo cards would stay visible until a feed refresh

@cmadeo when you say feed refresh, do you mean feed refresh initiated by the user (aka pull to refresh) or feed reload that happens as the user scrolls, or feed reload that happens when new content slides in? I've experimented with dismissing the cards on every kind of feed refresh (user, scroll, new content reload) and in some cases, on scroll, the cards go away too quickly 🤔 for example:

  1. I open the feed, all the cards but the global ones are visible
  2. I go to Settings and turn off all the cards but On this day (or some other non-global card)
  3. I go back to Explore
  4. I tap on the overflow menu on one of the One this day cards
  5. I choose to hide all On this day cards

At this point my feed has the announcement cards and the collapsed On this day card:

IMG_99C7636F664E-1.jpeg (2×1 px, 487 KB)
bold text

Now if I scroll anywhere in the feed, the collapsed card will disappear right away

Also, if I put the app in the background and then reopen it, would I want to see the collapsed cards in the feed? I think the easiest thing to do would be to clean up the cards when the user leaves the feed (by going to another view or closing the app) but if all they do is hang out in the feed then it may become polluted with those collapsed cards

Also, just to make sure 😅 - do we want to collapse cards if the user chooses "Customize Explore feed"? If they turn off a bunch of cards, we wouldn't know what to collapse unless we pick a random card of the same kind they turned off and collapse it 🧐

Thanks for laying all of these options out so clearly! I’m sorry I really
should have thought through these flows more!

Your proposal for only clearing collapsed cards when a user leaves the feed
makes sense to me! So just to be clear, if a user refreshes their feed
(pull from top) we’ll keep the collapsed cards until they navigate away
from the feed? If so this sound good to me!

If the user chooses to ‘customize the explore feed’ let’s treat this the
same way as we would a user navigating to settings to customize their feed.
So, yeah, no expectation that collapsed cards would appear in the feed.

Thank you!

@NHarateh_WMF this is looking so good!

One small tweak:
Can we have the padding above and below the collapsed card be even?

Simulator Screen Shot - iPhone 6 - 2018-07-24 at 12.28.01.png (1×750 px, 203 KB)