Page MenuHomePhabricator

Security review of psr/simple-cache PHP library
Closed, ResolvedPublic

Description

Wikibase is going to use PSR-16-compliant simple CacheInterface as a generic cache interface in PHP code.

We are going to use psr/simple-cache library that defines the interface, and relevant extensions.
As the library is not part of the mediawiki vendor component yet, it would need to go through the security review, so it could be used in Wikibase extension.

Source code of the library is at: https://github.com/php-fig/simple-cache.

We are intending to use the most recent version 1.0.1 of the library.
The library does not have dependencies.

The library only defines interfaces. Implementations of particular cache services (e.g. decorated BagOStuff implementations) will be provided in Wikibase code base.

Should any further information needed to be provided, Wikidata developers (WMDE) should be able to do it.

Event Timeline

Change 443972 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/vendor@master] DNM Added psr/simple-cache 1.0.1

https://gerrit.wikimedia.org/r/443972

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.
Reedy added a subscriber: Reedy.Jul 11 2018, 1:12 PM

Yeah, no security review needed here. There is no functional code, just a few interfaces

Addshore closed this task as Resolved.Jul 11 2018, 1:12 PM
Addshore claimed this task.

Thus, closing as resolved, we will add it to mediawiki-vendor

Change 443972 merged by jenkins-bot:
[mediawiki/vendor@master] Added psr/simple-cache 1.0.1

https://gerrit.wikimedia.org/r/443972