Page MenuHomePhabricator

`id="mw-htmlform-opt-out"` occuring twice in DOM
Closed, ResolvedPublic

Description

Current DOM output of OOUIified Special:Preferences features id="mw-htmlform-opt-out" twice in resulting DOM.
It's actually not a feature, it's a bug.

  1. #mw-prefsection-rc-opt-out > .oo-ui-fieldsetLayout-group > div > div
  2. #mw-prefsection-watchlist-opt-out > .oo-ui-fieldsetLayout-group > div > div

Event Timeline

Volker_E triaged this task as Normal priority.Jul 5 2018, 4:23 PM
Volker_E created this task.
Volker_E updated the task description. (Show Details)Jul 5 2018, 4:26 PM

The ID is also used twice in the non-OOUI form.

Change 444038 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Avoid duplicate IDs on Special:Preferences

https://gerrit.wikimedia.org/r/444038

matmarex claimed this task.Jul 5 2018, 6:39 PM

Change 444038 merged by jenkins-bot:
[mediawiki/core@master] Avoid duplicate IDs on Special:Preferences

https://gerrit.wikimedia.org/r/444038

matmarex closed this task as Resolved.Jul 8 2018, 11:08 AM
matmarex removed a project: Patch-For-Review.