Maniphest T198894

Review Mitmachen JavaScript for performance and security
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Cirdan
	Jul 5 2018, 5:28 PM

Description

All JavaScript is currently in mitmachen.js.

I'm not a JavaScript programmer and while it works, the code is probably quite fragile and perhaps even insecure. A review by an experienced developer is needed.

Event Timeline

Cirdan created this task.Jul 5 2018, 5:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2018, 5:28 PM

Cirdan edited projects, added Mitmachen; removed User-Cirdan.Jul 6 2018, 10:19 AM

Cirdan moved this task from Backlog to Code Review on the Mitmachen board.Jul 6 2018, 10:25 AM

Aklapper unsubscribed.Jul 6 2018, 2:31 PM

Cirdan updated the task description. (Show Details)Jul 9 2018, 9:31 AM

• RazShuty claimed this task.Aug 8 2018, 1:47 PM

Thanks for the review! If I have any questions regarding your comments, I'll ping you on GitHub.

This code is so small that code quality issues are almost not relevant.

I did not spot any security issues. It's been a while since i used jQuery though. Still, I'd be very surprised if there was an issue.

Just realized Raz already reviewed the code at https://github.com/ionicsolutions/mitmachen/issues. He spotted everything else (and more) that I was going to mention here.

Resetting assignee as that account has been disabled. Is there anything left to do in this task?

@Cirdan: Do you know?

@Aklapper Sorry for the late reply. This task is obsolete, as development of Mitmachen has been taken over by WMDE and they (hopefully... ;-)) rewrote major parts of the app.

Review Mitmachen JavaScript for performance and securityClosed, ResolvedPublicActions

Description

Event Timeline

Review Mitmachen JavaScript for performance and security
Closed, ResolvedPublic
Actions