Page MenuHomePhabricator

Decide what to do in apps when in-the-news sections contain only links
Open, NormalPublic

Description

Background information

In T198904: Fix nowiki's in-the-news section to work for apps users we found a problem with the user content that was being read for the feed. The news feed expects a particular format and we manually add wikis to the list of feeds. When the UGC went "bad" (non-conformant), the resulting output from the service was poor, to the extent that the feature looked broken in the apps.

This task is to consider whether we should do anything on the server side to try to prevent this becoming an issue.

Open questions

  1. Should we drop a news item if it doesn't have a story?
    • Yes
  2. Should we drop the whole news property under certain conditions, let's say no news item has has a story?
    • Yes

Acceptance criteria

  • Drop a news item if it doesn't have a story
    • Add a warning in the logs for when we drop a news item because it doesn't have a story
  • Drop the whole news property:
    • When there are no news items left on the key

Dev notes

The Drop the whole news property probably needs to be done in Restbase (via @bearND)

Event Timeline

Jhernandez triaged this task as High priority.Jul 6 2018, 10:47 AM
Jhernandez added a subscriber: Jhernandez.

Please, could you flesh out a description of the previous situation, the new situation, and possible solutions so that they can be discussed?

JMinor lowered the priority of this task from High to Normal.Jul 9 2018, 6:37 PM
JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.
bearND added a subscriber: bearND.Jul 9 2018, 8:16 PM

I wonder if there's anything we should do on the server side.
Should we drop a news item if it doesn't have a story?
Should we drop the whole news property under certain conditions, let's say no news item has has a story?
If we end up doing anything like that we should at least emit some sort of warning in the logs.

Thanks @bearND, stole your comment shamelessly when I finally filled out the description. :-)

Jhernandez updated the task description. (Show Details)Jan 23 2019, 4:59 PM
Jhernandez updated the task description. (Show Details)
bearND updated the task description. (Show Details)Jan 23 2019, 5:02 PM