Page MenuHomePhabricator

Switch TemplateWizard dialog to smaller size
Closed, ResolvedPublic0.5 Estimated Story Points

Description

The dialog size should be the same as the size for Dialog with dropdowns ($overlay test) in the demos.

image.png (828×1 px, 191 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We are currently matching what TemplateData does with the dialog for editing templatedata. It's set to the window height minus 200 px. The Dialog with dropdowns ($overlay test) is hard-coded at 300 px, and I reckon that's a little bit too small: when there are lots of parameters, it gets annoying to scroll up and down a lot, especially as the add/remove all button takes up a bit of vertical space too.

How about 500 px?

(And of course these are max values; if the window is smaller, the dialog box gets shrunk.)

We are currently matching what TemplateData does with the dialog for editing templatedata. It's set to the window height minus 200 px. The Dialog with dropdowns ($overlay test) is hard-coded at 300 px, and I reckon that's a little bit too small: when there are lots of parameters, it gets annoying to scroll up and down a lot, especially as the add/remove all button takes up a bit of vertical space too.

How about 500 px?

(And of course these are max values; if the window is smaller, the dialog box gets shrunk.)

Sure. Let's make a patch and put it up on commtech wiki so Carolyn can look at it and we'll see what she thinks.
This ticket isn't estimated but it sounds very easy so feel free to throw points on it and put it in the sprint if you don't have anything else to work on,

Change 447014 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/TemplateWizard@master] Set main dialog window height to 500

https://gerrit.wikimedia.org/r/447014

Samwilson set the point value for this task to 0.5.

Sure. It's on commtechwiki now, with the 500 px height.

Interestingly, the way TemplateData does it is pretty annoying on a small screen, because it doesn't let the top and bottom margins on the dialog window get any smaller.

@cmadeo Could you take a look at this? See older comments on ticket for more context. Steps to check:

  1. Go to http://commtech.wmflabs.org/w/index.php?title=Main_Page (you'll need to login)
  2. Edit the page and open TemplateWizard
  3. Use 'Citation' or 'Test' templates to test with.

My personal feeling is that this looks too square and having it be more rectangle-y looked nicer but I'm not a designer. :)

No need to log in, just edit one of the other (non mainpage) pages. Anons can edit them.

@Niharika + @Samwilson, it's definitely more square than the mocks, but it doesn't bother me. Since most templates will be longer than they are wide, this might work out better for being able to see more fields at once anyway :)

Change 447014 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Set main dialog window height to 500

https://gerrit.wikimedia.org/r/447014

Niharika moved this task from QA to Q1 2018-19 on the Community-Tech-Sprint board.