Page MenuHomePhabricator

WikibaseKnownTypesTests.test_datatypes is failing on beta cluster tests
Closed, ResolvedPublic

Description

https://travis-ci.org/wikimedia/pywikibot/jobs/400546130#L1379

self = <tests.paraminfo_tests.WikibaseKnownTypesTests testMethod=test_datatypes>
    def test_datatypes(self):
        """Test that all encountered datatypes are known."""
        unsupported = {'wikibase-form', 'wikibase-lexeme'}  # T194890
        known = set(Property.types) | unsupported
        self._check_param_superset(
>           self.repo, 'wbformatvalue', 'datatype', known)
tests/paraminfo_tests.py:235: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/paraminfo_tests.py:53: in _check_param_superset
    self.assertGreaterEqual(set(expected), set(values))
E   AssertionError: {'wikibase-lexeme', 'wikibase-property', 'time', 'wikibase-form', 'quantity', 'globe-coordinate', 'math', 'tabular-data', 'monolingualtext', 'wikibase-item', 'string', 'url', 'external-id', 'geo-shape', 'commonsMedia'} not greater than or equal to {'wikibase-sense', 'wikibase-lexeme', 'wikibase-property', 'time', 'wikibase-form', 'globe-coordinate', 'quantity', 'math', 'monolingualtext', 'tabular-data', 'wikibase-item', 'string', 'url', 'external-id', 'geo-shape', 'commonsMedia'}

(There is a new data type: wikibase-sense)

Event Timeline

Dalba triaged this task as High priority.Jul 6 2018, 2:56 AM

Change 444148 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] WikibaseKnownTypesTests: Add 'wikibase-sense' to unsupported types

https://gerrit.wikimedia.org/r/444148

Change 444148 merged by jenkins-bot:
[pywikibot/core@master] WikibaseKnownTypesTests: Add 'wikibase-sense' to unsupported types

https://gerrit.wikimedia.org/r/444148

Dvorapa claimed this task.

It seems resolved, but T198999 occured after the fix

It seems resolved, but T198999 occured after the fix

Must have been a pure coincidence, the fix was a minor change in the test suite, not the framework.