Page MenuHomePhabricator

Wikibase tests are failing CI on unrelated changes
Closed, ResolvedPublic

Description

On https://gerrit.wikimedia.org/r/c/mediawiki/core/+/442153 the mediawiki-extensions-hhvm-jessie, mediawiki-extensions-php70-jessie, and mediawiki-extensions-qunit-jessie jobs are failing, apparently due to a bunch of files missing in the Wikibase extension installation.

Event Timeline

Anomie created this task.Jul 6 2018, 3:01 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 6 2018, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Anomie triaged this task as Unbreak Now! priority.Jul 6 2018, 3:01 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJul 6 2018, 3:01 PM
Daimona added a subscriber: Reedy.
Daimona added a subscriber: Daimona.
hashar assigned this task to thcipriani.Jul 6 2018, 5:10 PM
hashar added subscribers: thcipriani, hashar.

Wikibase .gitmodule has:

[submodule "view/lib/wikibase-data-model"]
	path = view/lib/wikibase-data-model
	url = https://phabricator.wikimedia.org/source/wikibase-data-model.git

The repository on Diffusion was out of date somehow. It got refreshed by @thcipriani

Updates OK Last updated Fri, Jul 6, 7:07 PM (1 m, 51 s ago).

Maybe we should point all the .gitmodules to point to Gerrit which is the canonical source of code and will always be up to date.

thcipriani closed this task as Resolved.Jul 6 2018, 5:42 PM
thcipriani reassigned this task from thcipriani to Tarrow.
thcipriani added a subscriber: Tarrow.

Tests that were failing seem to be passing now. Calling this resolved, reopen if there are still failures. Assigning to @Tarrow as I just clicked the buttons.