Page MenuHomePhabricator

[MOOC] MoocContentHandler::makeEmptyContent() did not return a valid content (MoocContent::isValid())
Closed, DeclinedPublic

Description

00:01:45.528 1) ContentHandlerSanityTest::testMakeEmptyContent with data set #0 (MoocContentHandler Object (...))
00:01:45.529 MoocContentHandler::makeEmptyContent() did not return a valid content (MoocContent::isValid())
00:01:45.529 Failed asserting that false is true.

On a dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MOOC/+/444388/

Event Timeline

hashar created this task.Jul 7 2018, 8:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2018, 8:47 PM

@Sebschlicht when creating an empty content with MoocContentHandler::makeEmptyContent() it is not considered valid by MoocContent::isValid().

Seems MoocEntity::fromJson returns null when the entity type is not set :-\ That breaks the mediawiki core test ContentHandlerSanityTest::testMakeEmptyContent which ensure that makeEmptyContent() returns a content that is valid.

Change 454836 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/core@master] Temp hack for empty MoocContent not being valid

https://gerrit.wikimedia.org/r/454836

Change 454837 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/MOOC@master] Dummy test for T199032

https://gerrit.wikimedia.org/r/454837

Change 454856 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate MOOC to Quibble

https://gerrit.wikimedia.org/r/454856

Change 454837 abandoned by Hashar:
Dummy test for T199032

https://gerrit.wikimedia.org/r/454837

Change 454836 abandoned by Hashar:
Temp hack for empty MoocContent not being valid

Reason:
I will archive it instead. Thanks

https://gerrit.wikimedia.org/r/454836

Change 454856 merged by jenkins-bot:
[integration/config@master] Archive MOOC extension

https://gerrit.wikimedia.org/r/454856

Zoranzoki21 closed this task as Declined.Dec 31 2018, 7:12 AM
Zoranzoki21 added a subscriber: Zoranzoki21.

Closing as declined because of archival per T202803.