00:01:45.528 1) ContentHandlerSanityTest::testMakeEmptyContent with data set #0 (MoocContentHandler Object (...)) 00:01:45.529 MoocContentHandler::makeEmptyContent() did not return a valid content (MoocContent::isValid()) 00:01:45.529 Failed asserting that false is true.
On a dummy change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MOOC/+/444388/
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T190097 Migrate all CI jobs from Nodepool, deprecate its use | |||
| Resolved | hashar | T183512 [EPIC] Migrate Mediawiki jobs from Nodepool to Docker | |||
| Declined | None | T199032 [MOOC] MoocContentHandler::makeEmptyContent() did not return a valid content (MoocContent::isValid()) |
@Sebschlicht when creating an empty content with MoocContentHandler::makeEmptyContent() it is not considered valid by MoocContent::isValid().
Seems MoocEntity::fromJson returns null when the entity type is not set :-\ That breaks the mediawiki core test ContentHandlerSanityTest::testMakeEmptyContent which ensure that makeEmptyContent() returns a content that is valid.
Change 454836 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/core@master] Temp hack for empty MoocContent not being valid
Change 454837 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/MOOC@master] Dummy test for T199032
Change 454856 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate MOOC to Quibble
Change 454836 abandoned by Hashar:
Temp hack for empty MoocContent not being valid
Reason:
I will archive it instead. Thanks
Change 454856 merged by jenkins-bot:
[integration/config@master] Archive MOOC extension