Page MenuHomePhabricator

Creating subtasks sets more restrictive edit permissions than parent task: Others cannot edit such subtasks anymore
Closed, ResolvedPublic

Description

Kosta and Cindy reported this to me in the last days when they wanted to edit a (sub)task someone else had filed:

When selecting "Edit related tasks" and then "Create subtask", those tasks were set to "Can Edit: Task author, Administrators, WMF-NDA". There are no signs of policy changes in the log so it looks like this policy was set on task creation.

The subtask author did not get the fields "Visible To" and "Editable By" when editing the subtasks.

Event Timeline

Aklapper triaged this task as High priority.Jul 9 2018, 3:58 PM
Aklapper created this task.

Why would "Task author, administrators, WMF-NDA" deny the author?

Aklapper renamed this task from Creating subtasks sets more restrictive edit permissions than parent task: Author cannot edit their subtask anymore to Creating subtasks sets more restrictive edit permissions than parent task: Others cannot edit such subtasks anymore.Jul 10 2018, 9:20 AM
Aklapper updated the task description. (Show Details)

Sorry, that was my fault getting it wrong. No author involved; corrected now.

I changed the default edit policy here.

I changed the default edit policy here.

This seems to confuse [some] people. I've received messages by four people (WMF, WMDE) so far who wondered what's wrong and 'how to get rights'.
(This does not mean that we should revert this change completely but that we'll probably need to adjust the criteria or how to add people automagically. Somehow.)

I can confirm this is not only confusing but *really* annoying and disturbing in daily work on Phabricator. To be honest I personally can't see any reason why this should be useful in any way, but even if some projects may want this, there's no reason to force this on all of them and effectively making collaborating impossible in huge parts of Phabricator.

mmodell claimed this task.

This should be resolved now: I changed default edit policy on maniphest tasks back to "all users" until a better solution can be found.

I went through remaining open tasks which have open parent tasks filed between 20180710 and 20180731 and reset the Edit Policy to All Users for those tasks in S1 with View Policy set to Public.