Page MenuHomePhabricator

[wmf.10 -regression] Highlight pencil icon missing for Namespace and Tags filters
Closed, ResolvedPublic


The issue is present in betalabs too. As far as I checked, the issue is present in MacOS (Chrome, FF, Safari) and Windows (IE, Chrome, FF).

When 'Highlight results' is clicked for Namespace and Tags filters, the pencil icon is missing.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2018, 7:09 PM
Etonkovidova updated the task description. (Show Details)Jul 9 2018, 7:10 PM

This seems to happen because the mw-rcfilters-ui-filterItemHighlightButton-circle class is always there, even when no circle is displayed, and that class sets background-image: none. Looks like a regression from the recent changes to how highlight circles work.

Catrope added a comment.EditedJul 10 2018, 5:49 PM

Correction: I think this is a regression from @kostajh's changes to highlight handling on initialization. If you choose a color then choose no color, the pencil comes back. So it looks like this code isn't getting run on init:

Change 444927 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Explicitly set the default default highlight color to null

Catrope claimed this task.Jul 10 2018, 5:58 PM
Catrope moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change 444927 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Explicitly set the default highlight color to null

@Catrope, @kostajh - there seems to be another regression after this fix - the filter names are misaligned:

vs. current production

Note: checked highlight icons in betalabs - they are back in place.

@Etonkovidova Can you file a new task for the checkbox alignment issue? It is present in all filter views (filters, tags, namespaces) and it is very unlikely to be related to the fix for the missing pencil icons. I suspect an OOUI change.