Page MenuHomePhabricator

Add statements section to senses
Closed, ResolvedPublic

Description

Right now, senses just have a placeholder “STATEMENTS GO HERE” in the UI. Replace this with an actual statements section, and then see how the editing works out…

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterUse a real entity changer when editing statements of a sense

Event Timeline

Real senses apparently already get a statements section, see T198198#4427241. However, editing doesn’t work yet because resources/view/ControllerViewFactory.js uses a fakeEntityChangersFactory which doesn’t save anything, and when you replace that with the real entityChangersFactory, the API responds with an error that “$serialization contains invalid EntityId: The serialization L3-S1 is not recognized by the configured id builders”.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 31 2018, 9:50 AM

Change 449435 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Use a real entity changer when editing statements of a sense

https://gerrit.wikimedia.org/r/449435

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 31 2018, 10:40 AM

and when you replace that with the real entityChangersFactory, the API responds with an error that “$serialization contains invalid EntityId: The serialization L3-S1 is not recognized by the configured id builders”.

It looks like this has been fixed in the meantime, probably by the wbeditentity integration in the I5be82090d4 chain.

Oops, change has CI issues and isn’t merged yet.

Change 449435 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use a real entity changer when editing statements of a sense

https://gerrit.wikimedia.org/r/449435

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 31 2018, 3:03 PM