Maniphest T199211

Add statements section to senses
Closed, ResolvedPublic
Actions

Description

Right now, senses just have a placeholder “STATEMENTS GO HERE” in the UI. Replace this with an actual statements section, and then see how the editing works out…

Details

	Subject	Repo	Branch	Lines +/-
	Use a real entity changer when editing statements of a sense	mediawiki/extensions/WikibaseLexeme	master	+7 -19

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T196270 Editing Senses
Resolved	Ladsgroup	T196276 Add additional statement
Resolved	Ladsgroup	T199211 Add statements section to senses

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 10 2018, 11:38 AM

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Jul 11 2018, 8:58 AM

Real senses apparently already get a statements section, see T198198#4427241. However, editing doesn’t work yet because resources/view/ControllerViewFactory.js uses a fakeEntityChangersFactory which doesn’t save anything, and when you replace that with the real entityChangersFactory, the API responds with an error that “$serialization contains invalid EntityId: The serialization L3-S1 is not recognized by the configured id builders”.

Ladsgroup claimed this task.Jul 31 2018, 9:50 AM

Ladsgroup added a project: Wikidata-Senses-Iteration2.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 31 2018, 9:50 AM

Ladsgroup moved this task from To Do to Doing on the Wikidata-Senses-Iteration2 board.Jul 31 2018, 9:53 AM

Change 449435 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Use a real entity changer when editing statements of a sense

https://gerrit.wikimedia.org/r/449435

gerritbot added a project: Patch-For-Review.Jul 31 2018, 10:07 AM

Ladsgroup mentioned this in rEWLE1b63b6cf5ecd: Use a real entity changer when editing statements of a sense.Jul 31 2018, 10:08 AM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration2 board.Jul 31 2018, 10:12 AM

and when you replace that with the real entityChangersFactory, the API responds with an error that “$serialization contains invalid EntityId: The serialization L3-S1 is not recognized by the configured id builders”.

It looks like this has been fixed in the meantime, probably by the wbeditentity integration in the I5be82090d4 chain.