Page MenuHomePhabricator

Setup a cirrussearch branch for es 6.x and make it work
Closed, ResolvedPublic

Description

With the plugins all ported over we are ready to start migrating cirrussearch itself to elastic 6. Setup a branch, much like we did for elastic 5.x migration, and get it passing all the tests with elastic 6.

It would be nice if cindy somehow worked too, but not necessary as a first step.

Event Timeline

EBernhardson triaged this task as Normal priority.Jul 10 2018, 5:36 PM
EBernhardson created this task.
EBernhardson moved this task from needs triage to Current work on the Discovery-Search board.

Change 446362 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@es6] Setup es6 branch

https://gerrit.wikimedia.org/r/446362

Change 446369 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Elastica@es6] Setup es6 branch

https://gerrit.wikimedia.org/r/446369

Change 446378 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/vendor@es6] Upgrade to elastica 6.0.2

https://gerrit.wikimedia.org/r/446378

I'm stuck on this because we still have to support HHVM but unfortunately we can't activate hhvm.php7.scalar_types (see T173786#3688184). The new elasticsearch php client has many statements such as declare(strict_types = 1); which triggers this fatal error:
Fatal error: strict_types can only be used when hhvm.php7.scalar_types = true

Not sure what's the best way forward, we certainly can start evaluating es6 in our own vagrant but it's unlikely we will be able to rely on our CI infra while we still have to support HHVM without hhvm.php7.scalar_types set to true.

by forking the elasticsearch and use github zip export I could find a way to make it work, now cirrus tests are failing.
This should at least allow us to move forward.

Change 448546 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/es6] Setup es6 branch

https://gerrit.wikimedia.org/r/448546

Change 446362 abandoned by DCausse:
Setup es6 branch

Reason:
wrong branch

https://gerrit.wikimedia.org/r/446362

Change 448579 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Elastica@wmf/es6] Setup es6 branch

https://gerrit.wikimedia.org/r/448579

Change 448584 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/vendor@wmf/es6] Upgrade to elastica 6.0.2

https://gerrit.wikimedia.org/r/448584

Change 446369 abandoned by DCausse:
Setup es6 branch

Reason:
wrong branch

https://gerrit.wikimedia.org/r/446369

Change 446378 abandoned by DCausse:
Upgrade to elastica 6.0.2

Reason:
wrong branch

https://gerrit.wikimedia.org/r/446378

Change 448546 abandoned by DCausse:
Setup es6 branch

Reason:
wrong branch

https://gerrit.wikimedia.org/r/448546

Change 448584 abandoned by DCausse:
Upgrade to elastica 6.0.2

Reason:
wrong branch

https://gerrit.wikimedia.org/r/448584

Change 448579 abandoned by DCausse:
Setup es6 branch

Reason:
wrong branch

https://gerrit.wikimedia.org/r/448579

Change 446378 restored by DCausse:
Upgrade to elastica 6.0.2

https://gerrit.wikimedia.org/r/446378

Change 446369 restored by DCausse:
Setup es6 branch

https://gerrit.wikimedia.org/r/446369

Change 446362 restored by DCausse:
Setup es6 branch

https://gerrit.wikimedia.org/r/446362

Change 449450 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/Wikibase@master] [elastic] Add support for elasticsearch 6 fixtures

https://gerrit.wikimedia.org/r/449450

Change 446369 merged by EBernhardson:
[mediawiki/extensions/Elastica@es6] Setup es6 branch

https://gerrit.wikimedia.org/r/446369

Change 446378 merged by EBernhardson:
[mediawiki/vendor@es6] Upgrade to elastica 6.0.2

https://gerrit.wikimedia.org/r/446378

Change 449450 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] [elastic] Add support for elasticsearch 6 fixtures

https://gerrit.wikimedia.org/r/449450

Change 446362 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@es6] Setup es6 branch

https://gerrit.wikimedia.org/r/446362

I suppose it's debatable if this is done. While you can upgrade from 5.x -> 6.x, you can't create new indices in 6.x. That is tracked in T200198 so this seems done.