Page MenuHomePhabricator
Create Task
Maniphest T199275

PHP error "Undefined index: error in CirrusSearch/includes/BaseInterwikiResolver.php"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

type:hhvm
Notice: Undefined index: error in /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/BaseInterwikiResolver.php on line 221
type:mediawiki channel:error
#0 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/BaseInterwikiResolver.php(221): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/BaseInterwikiResolver.php(166): CirrusSearch\BaseInterwikiResolver->sendConfigDumpRequest(array)
#2 /srv/mediawiki/php-1.32.0-wmf.10/includes/libs/objectcache/BagOStuff.php(168): Closure$CirrusSearch\BaseInterwikiResolver::loadConfigFromAPI()
#3 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/BaseInterwikiResolver.php(168): BagOStuff->getWithSetCallback(string, integer, Closure$CirrusSearch\BaseInterwikiResolver::loadConfigFromAPI;1290)
#4 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/BaseInterwikiResolver.php(65): CirrusSearch\BaseInterwikiResolver->loadConfigFromAPI(array, array, array)
#5 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/InterwikiSearcher.php(75): CirrusSearch\BaseInterwikiResolver->getSisterProjectConfigs()
#6 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/CirrusSearch.php(379): CirrusSearch\InterwikiSearcher->getInterwikiResults(string)
#7 /srv/mediawiki/php-1.32.0-wmf.10/extensions/CirrusSearch/includes/CirrusSearch.php(178): CirrusSearch->searchTextReal(string, CirrusSearch\SearchConfig)
#8 /srv/mediawiki/php-1.32.0-wmf.10/includes/search/SearchEngine.php(81): CirrusSearch->doSearchText(string)
#9 /srv/mediawiki/php-1.32.0-wmf.10/includes/search/SearchEngine.php(167): Closure$SearchEngine::searchText()
#10 /srv/mediawiki/php-1.32.0-wmf.10/includes/search/SearchEngine.php(82): SearchEngine->maybePaginate(Closure$SearchEngine::searchText;1063)
#11 /srv/mediawiki/php-1.32.0-wmf.10/includes/specials/SpecialSearch.php(319): SearchEngine->searchText(string)
#12 /srv/mediawiki/php-1.32.0-wmf.10/includes/specials/SpecialSearch.php(185): SpecialSearch->showResults(string)
#13 /srv/mediawiki/php-1.32.0-wmf.10/includes/specialpage/SpecialPage.php(565): SpecialSearch->execute(NULL)
#14 /srv/mediawiki/php-1.32.0-wmf.10/includes/specialpage/SpecialPageFactory.php(569): SpecialPage->run(NULL)
#15 /srv/mediawiki/php-1.32.0-wmf.10/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#16 /srv/mediawiki/php-1.32.0-wmf.10/includes/MediaWiki.php(867): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.32.0-wmf.10/includes/MediaWiki.php(524): MediaWiki->main()
#18 /srv/mediawiki/php-1.32.0-wmf.10/index.php(42): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): include(string)
#20 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop support for loading external config from wgConfmediawiki/extensions/CirrusSearchmaster+695 -309
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 10 2018, 8:42 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptJul 10 2018, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle added a project: Wikimedia-production-error.Jul 10 2018, 8:42 PM
• EBjune triaged this task as Medium priority.Jul 12 2018, 5:03 PM
• EBjune subscribed.

Looks like it could have been a brief and non-recurring hiccup, we'll keep an eye on it and try to diagnose any further instances as they occur.

• EBjune added a comment.Jul 12 2018, 5:06 PM

Actually, this aligns with recent downtime instances, and reveals we're not handling errors properly in this case.

• EBjune moved this task from needs triage to Tech Debt/Misc on the Discovery-Search board.Jul 12 2018, 5:06 PM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Jul 13 2018, 9:22 PM
Krinkle closed this task as Resolved.Jul 31 2018, 6:39 PM

Last seen in production during 1.32.0-wmf.10 and and 1.32.0-wmf.12. Zero matche for wmf.13 or wmf.14. Marking as resolved for now.

dcausse claimed this task.Oct 5 2018, 3:57 PM
gerritbot subscribed.Oct 5 2018, 4:02 PM

Change 464055 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Drop support for loading external config from wgConf

https://gerrit.wikimedia.org/r/464055

gerritbot added a project: Patch-For-Review.Oct 5 2018, 4:02 PM
gerritbot added a comment.Oct 5 2018, 6:34 PM

Change 464055 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Drop support for loading external config from wgConf

https://gerrit.wikimedia.org/r/464055

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 5 2018, 7:00 PM
dcausse merged a task: T206794: BaseInterwikiResolver.php: PHP Notice "Undefined index: error".Oct 11 2018, 8:55 PM
Krinkle moved this task from Mar 2021 to Older on the Wikimedia-production-error board.Oct 11 2018, 8:57 PM
Krinkle added a project: Datacenter-Switchover.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits