Page MenuHomePhabricator

New Pages Feed: showing the filter logic (3.3)
Closed, ResolvedPublic


This task breaks out an item from a discussion in T195927.

When users apply filters to the New Pages Feed, their selections are shown at the top of the feed after the word "Showing:", like so:

image.png (85×437 px, 8 KB)

Currently, the logic is just that all selections (regardless of whether they are ANDs or ORs) are shown separated by commas.

In T195927, we are making the New Pages Feed filterable by ORES scores. That will add additional options to the filters, and include more complex AND and OR logic. The question arose about how to handle it, and the conversation from that task is copied below. This work is being broken out from T195927 because we will do the work in a separate patch.

Also keep in mind that "reviewed" status (in the PageTriage sense, not the AfC sense) is effectively ignored for Drafts, so we should probably not show that even if we're using it behind the scenes in the API call.

In T195927#4249525, @alexhollender wrote:


When model categories are selected, the selected categories should be listed next to the word "Showing" in the list's header. It would be great if @alexhollender could weigh in here on the logic of how to list the selected categories, taking into account the various possibilities for ANDs and ORs. This will be determined during the week of May 28.

  • I wonder if the distinction you're bringing up is relatively nuanced (it took me a few minutes to wrap my head around), i.e. maybe we should be weary of over-solving here. Unless the filter menu said something like "only show results that match all of the following criteria" I think the OR logic is implied. I assume the AND logic gets intuited because people are familiar with the filter options, however maybe we shouldn't rely on that going forward.
  • If I'm understanding this correctly, we don't currently make the distinction. If we did I believe the text for the following filter state would read: Showing (results that are): reviewed OR unreviewed OR nominated for deletion AND ARE orphans

Screen Shot 2018-05-31 at 1.25.43 PM.png (1×1 px, 188 KB)

  • I do think it would be helpful to call out which categories the applied filters are part of primarily to help familiarize people with the new filter structure we're introducing. This might also alleviate any confusion related to what you've called out. Hoping something like this would do the trick:

afc-active-filters.jpg (406×848 px, 227 KB)

Okay, thanks @alexhollender. It sounds like you're saying that right now the feed doesn't capture that nuance at all, so although we would not be making the logic worse by adding ORES and copyvio to it, it would exacerbate any ambiguity that currently exists. @Samwilson @MusikAnimal -- what do you think about whether it is worthwhile and easy to make that line read more clearly, like in Alex's mockup (the second image in his post)?

I think what it says now is fine ("Showing: unreviewed, nominated for deletion, orphans"). Changing that to "Showing: awaiting review, B-class, C-class, Attack, Low copyvio" is just as easy to understand, to me, since there's no crossover of values for each filter. Alex's mockup works great too, also easy to understand. Structuring it in this way should be easy to implement.

Thanks @MusikAnimal. Let's shoot for @alexhollender's version then, which I think will be a worthwhile investment in whatever the future of this feed becomes.

Event Timeline

Change 451815 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/PageTriage@master] [WIP] Group filtes in the filter list

@alexhollender @MMiller_WMF What should the "That:" category in NPP be called in this summary? It contains two page property things ("orphans" and "no categories"), but the others are all "created by". So we could, for example use either "Created by (newcomers)" or "Type (no categories)" depending on which kind of thing is selected.

Also, for NPP, for we want to list the namespace? We currently don't, but probably should.

For context, this is what things look like with my (work-in-progress) patch:

Screenshot from 2018-08-09 17-12-42.png (490×1 px, 74 KB)

@Catrope -- here are a couple options:

  1. Since the "That:" group is all radio buttons, the user can't select more than one. Our parentheses logic is there to distinguish ANDs from ORs. Since there won't be any ORs here, how about we just put the phrase right into the list, e.g. "State (reviewed, unreviewed), Are orphaned, Predicted class (b-class, c-class)".
  2. Give it the label of "Other", and just put the phrase in the parentheses, e.g. "Other (Were created by newcomers)".

For the options that are there now, I think we should use the whole phrase, but not use the things that are already in parentheses in the phrase. So we should use "Were created by newcomers", but not "Were created by newcomers (non-autoconfirmed users)".

And yes, I think we should list namespace. That can just be like, "Namespace (Article)".

SBisson added a subscriber: SBisson.

It failed to merge so bringing this back in Code Review until resolved

Change 451815 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Group filters in the filter list

Checked in betalabs:

  • "Show all" is not listed as a separate item.

Screen Shot 2018-08-16 at 2.46.50 PM.png (618×1 px, 158 KB)

  • "Were created by learners (newly autoconfirmed users)" is displayed as "By learners"

Screen Shot 2018-08-16 at 2.48.56 PM.png (597×1 px, 155 KB)

I just tried this out in Test Wiki. I see the same things as @Etonkovidova, but I think those two things are okay. I do, however, see a different issue, which I filed separately here: T203125

Having filed that, I am moving this task to Done.