Page MenuHomePhabricator

Current master code on wikistats breaks net bytes metric display
Closed, ResolvedPublic

Description

Please take a look at screenshot of net bytes metric:

/all-projects/content/net-bytes-difference/normal|bar|1-Year~2017063000~2018071100|~total

Event Timeline

Nuria created this task.Jul 11 2018, 12:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2018, 12:37 AM
Nuria added a comment.Jul 11 2018, 3:40 AM

I think the issues here are many

  • Our current code base makes it hard to decide whether there are dates missing for data returned because we do not return multiples of 12 for monthly data, rather we return 13 points for a year timespan (seems a bug).
  • the fill in dates function gets called even when it is not needed, thus shifting dates unnecessarily
  • even when I revert this change I still see an issue with pagecounts metric on console; "Error: <rect> attribute y: Expected length, "NaN"."
sahil505 closed this task as Resolved.Jul 12 2018, 6:48 AM
sahil505 assigned this task to mforns.

@Nuria : As we discusses yesterday, some of the issues were caused due to the bad rebase whereas others were coming from fill in dates function which was successfully removed by @mforns and also corrected the use of new Date() & Date,parse().

Shifting of bars due to null values is the issue that still persists which will be solved in coming days in T198630