Page MenuHomePhabricator
Create Task
Maniphest T199291

Remove LanguageGetMagic and LanguageGetSpecialPageAliases hooks (deprecated in 1.16) from MW Core
Closed, ResolvedPublic
Actions

Description

1.16? Seriously. DIE

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop the LanguageGetSpecialPageAliases and LanguageGetMagic hooksmediawiki/coremaster+4 -38
Remove LanguageGetMagic hookmediawiki/coremaster+1 -27
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jul 11 2018, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2018, 1:27 AM
Reedy added a subtask: T198173: [LabeledSectionTransclusion] Use of LanguageGetMagic hook (used in LabeledSectionTransclusion::setupMagic) was deprecated in MediaWiki 1.16.Jul 11 2018, 1:28 AM
Reedy added a project: Technical-Debt.
gerritbot subscribed.Jul 11 2018, 2:14 AM

Change 445058 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Remove LanguageGetMagic hook

https://gerrit.wikimedia.org/r/445058

gerritbot added a project: Patch-For-Review.Jul 11 2018, 2:14 AM
Reedy closed subtask T199292: Remove LanguageGetMagic hook subscribers in extensions as Resolved.Jul 11 2018, 11:21 AM
Jdforrester-WMF removed a subtask: T198173: [LabeledSectionTransclusion] Use of LanguageGetMagic hook (used in LabeledSectionTransclusion::setupMagic) was deprecated in MediaWiki 1.16.Jul 11 2018, 5:22 PM
Jdforrester-WMF reopened subtask T199292: Remove LanguageGetMagic hook subscribers in extensions as Open.
gerritbot added a comment.Jul 11 2018, 5:31 PM

Change 445058 abandoned by Legoktm:
Remove LanguageGetMagic hook

Reason:
Duplicate of Change-Id: Idcaf1b2c24c64653f700be4fe810ed124ba4ab7c

https://gerrit.wikimedia.org/r/445058

gerritbot added a comment.Jul 11 2018, 5:32 PM

Change 439793 had a related patch set uploaded (by Legoktm; owner: Jforrester):
[mediawiki/core@master] Drop the LanguageGetSpecialPageAliases and LanguageGetMagic hooks

https://gerrit.wikimedia.org/r/439793

Legoktm added a project: MW-1.32-release.Jul 11 2018, 5:33 PM
Legoktm subscribed.

This needs to wait until 1.32 to follow the deprecation policy since it was only hard deprecated in 1.31.

Legoktm edited projects, added MW-1.33-release; removed MW-1.32-release.Jul 11 2018, 5:34 PM

Err, hard deprecated in 1.32, will be removed in 1.33.

Jdforrester-WMF renamed this task from Remove LanguageGetMagic (deprecated in 1.16) from MW Core to Remove LanguageGetMagic and LanguageGetSpecialPageAliases hooks (deprecated in 1.16) from MW Core.Jul 11 2018, 6:32 PM
Jdforrester-WMF changed the task status from Open to Stalled.
Jdforrester-WMF subscribed.

Marking as stalled then.

Jdforrester-WMF closed subtask T199292: Remove LanguageGetMagic hook subscribers in extensions as Resolved.Jul 28 2018, 11:36 PM
Jdforrester-WMF mentioned this in T204863: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release.Sep 19 2018, 7:08 PM
Jdforrester-WMF mentioned this in T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release.Sep 20 2018, 8:40 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Sep 25 2018, 7:56 PM
Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.
Jdforrester-WMF closed this task as Resolved.Oct 30 2018, 5:58 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Oct 30 2018, 6:24 PM

Change 439793 merged by jenkins-bot:
[mediawiki/core@master] Drop the LanguageGetSpecialPageAliases and LanguageGetMagic hooks

https://gerrit.wikimedia.org/r/439793

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Oct 30 2018, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits