Page MenuHomePhabricator

Determine treatment for empty lines in diffs
Open, NormalPublic

Description

Background

In T197729 it was identified that the current treatment for empty lines is suboptimal in cases where an empty line addition or removal precedes or concludes a moved paragraph. A couple of solutions already suggested:

  • allow the marker to span the entire length of the line
  • place the moved paragraph arrow outside of the diff to make the separation between added/subtracted empty lines and moved paragraphs clearer

Acceptance criteria

TBC

Developer notes

As https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/444756/ shows, we can make these new lines full width. We can also remove the background color altogether or use 2 different colors.

There is also an opportunity in T90948 to rethink colors here.

We also talked about moving arrows outside the diff area (see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/444755/)