Maniphest T199307

Determine treatment for empty lines in diffs
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	ovasileva
	Jul 11 2018, 10:32 AM

Description

Background

In T197729 it was identified that the current treatment for empty lines is suboptimal in cases where an empty line addition or removal precedes or concludes a moved paragraph. A couple of solutions already suggested:

allow the marker to span the entire length of the line
place the moved paragraph arrow outside of the diff to make the separation between added/subtracted empty lines and moved paragraphs clearer

Acceptance criteria

TBC

Developer notes

As https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/444756/ shows, we can make these new lines full width. We can also remove the background color altogether or use 2 different colors.

There is also an opportunity in T90948 to rethink colors here.

We also talked about moving arrows outside the diff area (see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/444755/)

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Resolved		Halfak	T252280 Improve Wikilabels UI
Open		None	T105518 Make Wiki Labels mobile compatible
Open		None	T104072 Implement single column diff option (from mobile app)
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Open		None	T94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
Resolved		Petrb	T57793 Scoring should perhaps take into account added text rather than all text
Open		None	T100082 Provide useful diffs to high-volume consumers of recent changes
Open		None	T56328 Provide intraline diff format in API action=compare
Resolved		tstarling	T339184 MW core diff review/reorg/refactor
Open		None	T202763 Update extensions which customize content diff rendering
Declined		None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Resolved	BUG REPORT	Jdlrobson	T238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
Resolved		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Invalid		None	T199307 Determine treatment for empty lines in diffs
Resolved		• jkroll	T197729 wikidiff2 creating ins and del elements with single empty character element

Event Timeline

ovasileva created this task.Jul 11 2018, 10:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2018, 10:32 AM

ovasileva added a subtask: T197729: wikidiff2 creating ins and del elements with single empty character element.Jul 11 2018, 10:33 AM

Jdlrobson updated the task description. (Show Details)Jul 24 2018, 1:54 PM

Jdlrobson updated the task description. (Show Details)Jul 25 2018, 2:12 PM

Jdlrobson mentioned this in T197729: wikidiff2 creating ins and del elements with single empty character element.Aug 3 2018, 2:59 AM

Lea_WMDE closed subtask T197729: wikidiff2 creating ins and del elements with single empty character element as Resolved.Aug 3 2018, 6:47 AM

• alexhollender_WMF moved this task from Needs analysis to Next up on the Web-Team-Backlog (Design) board.Aug 9 2018, 11:11 PM

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 22 2018, 1:37 PM

Amorymeltzer subscribed.Sep 21 2019, 12:21 AM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Jdlrobson assigned this task to Edtadros.Apr 30 2021, 8:46 PM

Jdlrobson moved this task from Design to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Jdlrobson moved this task from QA Tasks / Needs Reproduction to Triaged but Future on the Web-Team-Backlog board.May 7 2021, 7:20 PM

Jdlrobson removed Edtadros as the assignee of this task.May 11 2021, 3:06 AM

Jdlrobson added a subscriber: Edtadros.

Jdlrobson added a parent task: T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).Jun 22 2021, 8:20 PM

Jdlrobson edited projects, added MediaWiki-Page-diffs, MobileFrontend (Tracking), Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Jun 25 2021, 7:22 PM

ovasileva moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Nov 10 2021, 3:37 PM

Jdlrobson removed a project: Web-Team-Backlog (Tracking).Dec 7 2021, 7:46 PM