Page MenuHomePhabricator

Develop a workflow to recommend / propose developers who should have +2 rights in Gerrit
Open, Needs TriagePublic

Description

Capacity building.
Making a final +2 decision can be one of the bottlenecks in our code review process. (Docs about granting: https://www.mediawiki.org/wiki/Gerrit/Project_ownership )

https://lists.wikimedia.org/pipermail/wikitech-l/2018-June/090222.html brought this to my mind again though I had already listed it under https://www.mediawiki.org/wiki/User:AKlapper_(WMF)/Code_Review#Lack_of_enough_skillful,_available,_confident_reviewers_and_mergers

Event Timeline

:)

I have some more thoughts that I'll post later but for now:

  • FInd out if we can use the list of most active contributors on https://wikimedi.biterg.io and how to best check which repositories they are the most active in

I've been using a search similar to https://gerrit.wikimedia.org/r/q/status:merged+project:mediawiki%252Fcore+-ownerin:mediawiki+-owner:L10n-bot+-ownerin:ldap%252Fwmf (h/t to Krenair for the search to replicate the filtering that I was doing manually) to identify potential +2 candidates.

The mediawiki group grants +2 to any repository under mediawiki/ in Gerrit, as well as some PHP libraries that are used by MediaWiki but predate the mediawiki/libs/ naming convention. There are also the individual extension-Foo groups that grant +2 for for that repository, and some other team/org based groups that are in the ACLs for related projects (e.g. Wikidata, ShoutWiki, the old editor-engagement group).

Isarra added a subscriber: Isarra.Jul 27 2018, 1:16 PM
Aklapper updated the task description. (Show Details)Jul 27 2018, 1:55 PM

High level, simplified:

  • Get a list of people who are the most active for each repository
  • Get a list of people who have +2 for each repository
  • Diff.

To get a list of people who have +2 per repository, I don't see any way via https://gerrit-review.googlesource.com/Documentation/rest-api-accounts.html (just getting a list of repositories for a specific user, which is the other way round). Any ideas?

D3r1ck01 updated the task description. (Show Details)Nov 17 2018, 8:36 PM
D3r1ck01 added a subscriber: D3r1ck01.
Aklapper renamed this task from Develop a workflow to propose handing out +2 rights in Gerrit to Develop a workflow to recommend / propose developers who should have +2 rights in Gerrit.Thu, Aug 22, 10:34 AM