Maniphest T199449

phan failing for Wikibase on wmf. branches
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Addshore
	Jul 12 2018, 2:55 PM

Tags

Referenced Files

None

Subscribers

Lydia_Pintscher

Description

Example: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/440295/

This is due to the extension directories existing for core on the wmf branches

Checks for these directories in the phan config then do the wrong thing
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/tests/phan/config.php#L62-L67
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/tests/phan/config.php#L97-L102

These checks need to be modified, perhaps just to make sure that the directory is not totally empty.

Related Objects

Mentioned Here: T195906: Phan fails for Wikibase on wmf.x branches

Event Timeline

Addshore created this task.Jul 12 2018, 2:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2018, 2:55 PM

Marking as high as this keeps slowing down deployments and increases the chances of some other failure being missed for backports.

Addshore added a project: Wikidata-Campsite.Jul 12 2018, 2:59 PM

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.Jul 12 2018, 3:02 PM

Is this a dupe of T195906. The other ticket has been resolved by always using stubs, i.e. https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/446809/

Poke ;-)

Addshore closed this task as a duplicate of T195906: Phan fails for Wikibase on wmf.x branches.Aug 18 2018, 1:30 PM

Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Aug 20 2018, 3:18 PM

Addshore removed a project: Wikidata-Campsite.Aug 22 2018, 9:56 AM