Page MenuHomePhabricator
Create Task
Maniphest T199466

[betalabs-regression] The filters' names are misaligned
Closed, ResolvedPublic
Actions

Description

The follow-up ticket for T199144: [wmf.10 -regression] Highlight pencil icon missing for Namespace and Tags filters

The filter names are misaligned:

Screen Shot 2018-07-11 at 1.05.32 PM.png (250×656 px, 27 KB)

vs. current production
Screen Shot 2018-07-11 at 1.05.19 PM.png (284×677 px, 26 KB)

Details

SubjectRepoBranchLines +/-
rcfilters: Fix filter menu checkbox alignment after OOUI v0.27.5 releasemediawiki/coremaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jul 12 2018, 5:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2018, 5:48 PM
Etonkovidova renamed this task from [betalabs-regression] The filter names are misalgned to [betalabs-regression] The filters' names are misaligned.Jul 12 2018, 5:49 PM
Etonkovidova mentioned this in T199144: [wmf.10 -regression] Highlight pencil icon missing for Namespace and Tags filters .
kostajh added a comment.Jul 12 2018, 11:00 PM

This broke in commit 1abbc3866661a4fe8e691a32c2f4edb3120b2c75

Jdforrester-WMF subscribed.Jul 13 2018, 5:33 PM

I'm not quite sure what in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/445234/1/resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css broke it, but a trivial fix is trivial. ;-)

gerritbot subscribed.Jul 13 2018, 5:34 PM

Change 445647 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] rcfilters: Fix filter menu checkbox alignment after OOUI v0.27.5 release

https://gerrit.wikimedia.org/r/445647

gerritbot added a project: Patch-For-Review.Jul 13 2018, 5:34 PM
Jdforrester-WMF claimed this task.Jul 13 2018, 5:37 PM
Jdforrester-WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Jdforrester-WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh reassigned this task from Jdforrester-WMF to Etonkovidova.Jul 13 2018, 6:47 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

thanks @Jdforrester-WMF!

gerritbot added a comment.Jul 13 2018, 7:01 PM

Change 445647 merged by jenkins-bot:
[mediawiki/core@master] rcfilters: Fix filter menu checkbox alignment after OOUI v0.27.5 release

https://gerrit.wikimedia.org/r/445647

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 13 2018, 8:00 PM
Etonkovidova closed this task as Resolved.Jul 13 2018, 8:49 PM

Fixed in betalabs.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL