Page MenuHomePhabricator
Create Task
Maniphest T199478

Gadgets should use the current skin, instead of the skin preference
Closed, ResolvedPublic
Actions

Description

The user's preference usually reflects the displayed skin, however this isn't
true if the useskin URL query is set, or MobileFrontend is being used.

Details

SubjectRepoBranchLines +/-
Fix skins option to use currently displayed skin, rather than user preferencemediawiki/extensions/Gadgetsmaster+70 -11
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Jul 12 2018, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2018, 9:25 PM
TheDJ triaged this task as Medium priority.Jul 12 2018, 9:27 PM
TheDJ mentioned this in T127147: Gadget definition "targets=mobile" seem to target mobile and desktop users on ur.wp.
TheDJ added a subscriber: Majr.
gerritbot subscribed.Jul 12 2018, 9:30 PM

Change 299950 had a related patch set uploaded (by TheDJ; owner: Majr):
[mediawiki/extensions/Gadgets@master] Fix skins option to use currently displayed skin, rather than user preference

https://gerrit.wikimedia.org/r/299950

gerritbot added a project: Patch-For-Review.Jul 12 2018, 9:30 PM
TheDJ added a comment.EditedJul 12 2018, 10:02 PM

Will need a fix for the api module. Makes me wonder what the implied behavior of isAllowed (and the corresponding api flag) is actually supposed to be. Would be nice if we could track down what the original intent was 'relevant to the user' or 'allowed for the user'. Did the first just get slapped onto the latter ?

See T33414: Skin specific gadgets
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Gadgets/+/3854/-1..3

gerritbot added a comment.Aug 3 2018, 6:53 PM

Change 299950 merged by jenkins-bot:
[mediawiki/extensions/Gadgets@master] Fix skins option to use currently displayed skin, rather than user preference

https://gerrit.wikimedia.org/r/299950

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 3 2018, 7:00 PM
TheDJ closed this task as Resolved.Aug 3 2018, 10:40 PM
TheDJ claimed this task.
TheDJ reassigned this task from TheDJ to Majr.
TheDJ removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL