Gadgets should use the current skin, instead of the skin preference
Open, NormalPublic

Description

The user's preference usually reflects the displayed skin, however this isn't
true if the useskin URL query is set, or MobileFrontend is being used.

TheDJ created this task.Thu, Jul 12, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jul 12, 9:25 PM

Change 299950 had a related patch set uploaded (by TheDJ; owner: Majr):
[mediawiki/extensions/Gadgets@master] Fix skins option to use currently displayed skin, rather than user preference

https://gerrit.wikimedia.org/r/299950

TheDJ added a comment.EditedThu, Jul 12, 10:02 PM

Will need a fix for the api module. Makes me wonder what the implied behavior of isAllowed (and the corresponding api flag) is actually supposed to be. Would be nice if we could track down what the original intent was 'relevant to the user' or 'allowed for the user'. Did the first just get slapped onto the latter ?

See T33414: Skin specific gadgets
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Gadgets/+/3854/-1..3