Maniphest T199484

Clicking on red link gives error "Uncaught TypeError: Cannot read property 'start' of null"
Closed, ResolvedPublic
Actions

Description

Click on a red link on read mode such as this one:

https://en.wikipedia.org/w/index.php?title=Examples/Red&action=edit&redlink=1

The following error appears:

VM108:1078 Uncaught TypeError: Cannot read property 'start' of null
    at jQuery.fn.init.getCaretPosition (<anonymous>:1078:106)
    at jQuery.fn.init.$.fn.textSelection (<anonymous>:108:121)
    at jQuery.fn.init.$.fn.wikiEditor (load.php?debug=false&lang=en&modules=ext.wikiEditor&skin=vector&version=03d7n1u:5)
    at Object.CiteTB.init (index.php?title=MediaWiki:RefToolbar.js&action=raw&ctype=text/javascript:128)
    at index.php?title=MediaWiki:RefToolbarConfig.js&action=raw&ctype=text/javascript:233

Details

	Subject	Repo	Branch	Lines +/-
	Wikitext surface getCaretPosition: Handle null ranges	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T200368: Javascript error when opening a page with ?action=edit

Event Timeline

Ryasmeen created this task.Jul 12 2018, 10:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2018, 10:03 PM

Schnark mentioned this in T200368: Javascript error when opening a page with ?action=edit.Jul 26 2018, 7:31 AM

I do not like errors in production, even if they do not seem to be causing any problems, because they often end up causing more problems down the line. Needs investigation.

• Deskana merged a task: T200368: Javascript error when opening a page with ?action=edit.Aug 7 2018, 6:59 PM

• Deskana added subscribers: • Whatamidoing-WMF, Schnark, Kaartic.

Looks like the editor is originating from gadget code, requesting a caret position from the editor when there is none, but we can guard against that.

Change 451392 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Wikitext surface getCaretPosition: Handle null ranges

https://gerrit.wikimedia.org/r/451392

gerritbot added a project: Patch-For-Review.Aug 8 2018, 6:00 PM

Change 451392 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Wikitext surface getCaretPosition: Handle null ranges

https://gerrit.wikimedia.org/r/451392

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 8 2018, 8:00 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Aug 9 2018, 3:03 AM

Ryasmeen added a project: Verified.Aug 9 2018, 5:19 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Aug 10 2018, 9:31 AM

• Deskana claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 10 2018, 9:31 AM

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM

If the fix for this has been deployed on 21Aug2018, I would like to inform that I still see the following error when visiting the link found in the task description.

TypeError: Argument 1 of Window.getComputedStyle is not an object.

I also get an error when visiting https://en.wikipedia.org/w/index.php?title=Wikipedia:Teahouse&action=edit&section=new which is the place in which I initially noticed this issue long before the proposed fix was made. The errors I get there is:

Argument 1 of Window.getComputedStyle is not an object.
TypeError: range is null, can't access property "end" of it

So, should this task be re-opened?

Clicking on red link gives error "Uncaught TypeError: Cannot read property 'start' of null" Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Clicking on red link gives error "Uncaught TypeError: Cannot read property 'start' of null"
Closed, ResolvedPublic
Actions