Page MenuHomePhabricator
Create Task
Maniphest T199502

Playback is not stopped when end of multi sentence selection is reached
Closed, ResolvedPublic
Actions

Description

When playing selected text and the selection spans multiple sentences, the playback doesn't stop when the end the selection is reached.

Details

SubjectRepoBranchLines +/-
Fix selection player not stopping when multiple sentences selectedmediawiki/extensions/Wikispeechmaster+29 -11
Customize query in gerrit

Related Objects

Event Timeline

Sebastian_Berlin-WMSE created this task.Jul 13 2018, 6:49 AM
Sebastian_Berlin-WMSE claimed this task.Jul 23 2018, 12:47 PM
Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.
gerritbot subscribed.Jul 23 2018, 3:10 PM

Change 447444 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Fix selection player not stopping when multiple sentences selected

https://gerrit.wikimedia.org/r/447444

gerritbot added a project: Patch-For-Review.Jul 23 2018, 3:10 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS1341a6e9f604: Fix selection player not stopping when multiple sentences selected.Jul 23 2018, 3:10 PM
Sebastian_Berlin-WMSE moved this task from This Week to Waitin' on the User-Sebastian_Berlin-WMSE board.Aug 16 2018, 7:02 AM
gerritbot added a comment.Aug 27 2018, 8:23 AM

Change 447444 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Fix selection player not stopping when multiple sentences selected

https://gerrit.wikimedia.org/r/447444

Sebastian_Berlin-WMSE closed this task as Resolved.Aug 27 2018, 1:20 PM
Sebastian_Berlin-WMSE moved this task from Waitin' to Done on the User-Sebastian_Berlin-WMSE board.
Sebastian_Berlin-WMSE merged a task: T192359: Player doesn't stop at the end of selection if multiple sentences are selected.Aug 31 2018, 8:43 AM
Stashbot subscribed.Sep 10 2018, 2:41 PM

Mentioned in SAL (#wikimedia-cloud) [2018-09-10T14:41:52Z] <sebastian-wmse> Deploy latest from Git master: a89d848, 1341a6e (T199502), f1a3a3b, b4071c4, 7d7cc45 (T201491), 100853e (T202047), 2277f27 (T133686)

Stashbot mentioned this in T201491: Fix common typos in code.Sep 10 2018, 2:41 PM
Stashbot mentioned this in T202047: CODE_OF_CONDUCT.md should link to the mediawiki.org page in user's preferred language.
Stashbot mentioned this in T133686: [Task] Adjustable speed of speech (Wikispeech).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL