Page MenuHomePhabricator
Create Task
Maniphest T199569

RTL and localization audit/issues
Closed, ResolvedPublic
Actions

Assigned To
Mhurd
Authored By
Mhurd
Jul 13 2018, 7:24 PM
Tags
Referenced Files
F24583762: T200239 Part 3.PNG
Aug 5 2018, 7:34 PM
F24583776: T200239 Part 6.PNG
Aug 5 2018, 7:34 PM
F24583780: T200239 Part 7.PNG
Aug 5 2018, 7:34 PM
F24583766: T200239 Part 4.PNG
Aug 5 2018, 7:34 PM
F24583791: T200239 Part 10.PNG
Aug 5 2018, 7:34 PM
F24583782: T200239 Part 8.PNG
Aug 5 2018, 7:34 PM
F24583758: T200239 Part 2.PNG
Aug 5 2018, 7:34 PM
F24583808: T200239 Part 15.PNG
Aug 5 2018, 7:34 PM
View All 26 Files
Subscribers
ABorbaWMF
Aklapper
Mhurd
Nicholas.tsg

Description

Repro steps:

To get good mix of LTR/RTL Explore content:

  • Clean install with EN device lang with additional Russian and Hebrew keyboards.
  • Tap through welcome screens to explore feed
  • THEN switch device lang to Hebrew

Note:
Screenshots below were taken with this PR (pixel push tweaks) which wasn't merged at the time.

Issues:

  • unclear if there's an alignment issue with this text...

Screen Shot 2018-07-24 at 5.43.16 PM.png (1×862 px, 134 KB)

  • switching device lang using repro steps above didn't switch search lang to Hebrew even though using Hebrew keyboard, which seems odd. to actually search Hebrew wiki i had to enable search langs and re-tap Hebrew button:

Screen Shot 2018-07-24 at 5.47.13 PM.png (1×862 px, 179 KB)

  • double-check if we have Hebrew translations for these strings. iirc we do...

Screen Shot 2018-07-24 at 5.50.14 PM.png (1×862 px, 205 KB)

  • incorrect text alignment

Screen Shot 2018-07-24 at 5.43.35 PM.png (1×862 px, 238 KB)

  • cell height not expanding correctly

Screen Shot 2018-07-24 at 5.49.11 PM.png (1×862 px, 239 KB)

  • these are always EN so should be LRT

Screen Shot 2018-07-24 at 5.50.59 PM.png (1×862 px, 266 KB)

  • incorrect RTL padding

Screen Shot 2018-07-24 at 5.42.12 PM.png (1×862 px, 484 KB)

  • incorrect text alignment

Screen Shot 2018-07-24 at 5.44.33 PM.png (1×862 px, 868 KB)

Screen Shot 2018-07-25 at 6.02.09 PM.png (1×862 px, 529 KB)

Screen Shot 2018-07-24 at 6.07.07 PM.png (1×862 px, 229 KB)

Related Objects

Event Timeline

Mhurd created this task.Jul 13 2018, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2018, 7:24 PM
Mhurd renamed this task from RTL audit/issues to RTL and localization audit/issues.Jul 13 2018, 7:27 PM
Mhurd updated the task description. (Show Details)
JoeWalsh added a project: iOS-app-v6.0-Walrus-On-A-Unicycle.Jul 23 2018, 6:40 PM
LGoto triaged this task as Medium priority.Jul 23 2018, 7:06 PM
Mhurd claimed this task.Jul 23 2018, 7:09 PM
JoeWalsh moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 24 2018, 2:12 PM
Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 25 2018, 12:27 AM
Mhurd updated the task description. (Show Details)Jul 25 2018, 1:05 AM
Mhurd updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)Jul 25 2018, 1:08 AM
Mhurd updated the task description. (Show Details)Jul 25 2018, 1:13 AM
Mhurd updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)Jul 26 2018, 1:03 AM
JoeWalsh mentioned this in rAPIOS3bea8dd4a990: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 26 2018, 5:47 PM
Diffusion mentioned this in rAPIOS0ec3654d78d8: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 26 2018, 6:30 PM
JoeWalsh mentioned this in rAPIOS94bde34a4928: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 26 2018, 6:48 PM
Diffusion mentioned this in rAPIOS4e4605cd6f6a: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 26 2018, 7:02 PM
• NHarateh_WMF mentioned this in rAPIOS8309c45a22af: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 26 2018, 10:12 PM
Diffusion mentioned this in rAPIOS57973917a785: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 27 2018, 5:50 PM
JoeWalsh mentioned this in rAPIOS35948fec0a4d: Merge branch 'develop' into fix/rtl-issues/T199569.Jul 27 2018, 6:39 PM
JoeWalsh mentioned this in rAPIOS094fc75e28de: Merge pull request #2501 from wikimedia/fix/rtl-issues/T199569.Jul 27 2018, 7:08 PM
Mhurd added a comment.Jul 28 2018, 2:09 AM

https://github.com/wikimedia/wikipedia-ios/pull/2501
https://github.com/wikimedia/wikipedia-ios/pull/2515

Mhurd updated the task description. (Show Details)Jul 28 2018, 2:11 AM
JoeWalsh mentioned this in rAPIOSff38b5bd6b9e: Merge branch 'develop' into fix/rtl-issues/T199569-2.Jul 30 2018, 1:03 PM
JoeWalsh mentioned this in rAPIOSa7a90085a87b: Merge pull request #2515 from wikimedia/fix/rtl-issues/T199569-2.Jul 30 2018, 1:19 PM
• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Jul 30 2018, 6:58 PM
Mhurd added a comment.Jul 31 2018, 2:35 AM

https://github.com/wikimedia/wikipedia-ios/pull/2525

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 31 2018, 7:21 AM
JoeWalsh mentioned this in rAPIOS67e03fafc61c: Merge pull request #2525 from wikimedia/fix/rtl-issues/T199569-3.Jul 31 2018, 10:45 AM
JoeWalsh moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Jul 31 2018, 4:04 PM
JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.0-Walrus-On-A-Unicycle board.
JoeWalsh moved this task from Needs Design Review to Needs QA on the iOS-app-v6.0-Walrus-On-A-Unicycle board.
JoeWalsh added a project: Product-QA.
Nicholas.tsg added subscribers: ABorbaWMF, Nicholas.tsg.Aug 5 2018, 7:34 PM

Testing Wikipedia 6.0.0 (1470) app on iOS 11.2.2 (iPhone 7). @ABorbaWMF I'm not sure if this is fixed, what I'll do is include the screencaps below of the different areas I have explored so that the staff can evaluate them.

T200239 Part 1.PNG (1×750 px, 96 KB)
T200239 Part 2.PNG (1×750 px, 141 KB)
T200239 Part 3.PNG (1×750 px, 146 KB)
T200239 Part 4.PNG (1×750 px, 154 KB)
T200239 Part 5.PNG (1×750 px, 187 KB)
T200239 Part 6.PNG (1×750 px, 56 KB)
T200239 Part 7.PNG (1×750 px, 151 KB)
T200239 Part 8.PNG (1×750 px, 183 KB)
T200239 Part 9.PNG (1×750 px, 140 KB)
T200239 Part 10.PNG (1×750 px, 300 KB)
T200239 Part 11.PNG (1×750 px, 393 KB)
T200239 Part 12.PNG (1×750 px, 160 KB)
T200239 Part 13.PNG (1×750 px, 270 KB)
T200239 Part 14.PNG (1×750 px, 316 KB)
T200239 Part 15.PNG (1×750 px, 1 MB)

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.0-Walrus-On-A-Unicycle board.Aug 6 2018, 4:42 PM
ABorbaWMF moved this task from Backlog to Done on the Product-QA board.Aug 7 2018, 4:51 PM
• JMinor closed this task as Resolved.Aug 27 2018, 9:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL