Page MenuHomePhabricator

"Warn" action should be repeated if the action changes
Closed, ResolvedPublic

Description

I noticed the following bug with the "warn" action. Create a catch-all filter with "warn" action and try to move a page. The warning will be shown as expected. Now, if I try to move the page again the warning isn't shown and the move goes through (and it's the same for edits: if you change the text after the warning, the edit will pass). However, instead of moving, try to delete the page after the warning: the deletion will succeed as well. I think we should reset the "warned" status if the action changes, since it's way too different from the move you were warned for.

Details

Event Timeline

Change 445778 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add the user action to warn key

https://gerrit.wikimedia.org/r/445778

Change 445778 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add the user action to warn key

https://gerrit.wikimedia.org/r/445778