Page MenuHomePhabricator
Create Task
Maniphest T199699

PageTriage performs unexpected db writes on GET request (TransactionProfiler warning from ArticleCompileProcessor)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

While investigating T154719, I came across many (~6500 in the last week) warnings like this one.

Expectation (writes <= 0) by MediaWiki::restInPeace not met (actual: 18):
query-m: REPLACE INTO `pagetriage_page_tags` (ptrpt_page_id,ptrpt_tag_id,ptrpt_value) VALUES ('X') [TRX#cd3e06]
#0 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/TransactionProfiler.php(219): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated()
#1 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(1243): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion()
#2 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(1143): Wikimedia\Rdbms\Database->doProfiledQuery()
#3 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(2772): Wikimedia\Rdbms\Database->query()
#4 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/DatabaseMysqlBase.php(518): Wikimedia\Rdbms\Database->nativeReplace()
#5 /srv/mediawiki/php-1.32.0-wmf.12/extensions/PageTriage/includes/ArticleCompile/ArticleCompileProcessor.php(243): Wikimedia\Rdbms\DatabaseMysqlBase->replace()
#6 /srv/mediawiki/php-1.32.0-wmf.12/extensions/PageTriage/includes/ArticleCompile/ArticleCompileProcessor.php(129): MediaWiki\Extension\PageTriage\ArticleCompile\ArticleCompileProcessor->save()
#7 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/MWCallableUpdate.php(34): Closure$MediaWiki\Extension\PageTriage\ArticleCompile\ArticleCompileProcessor::compileMetadata()
#8 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(268): MWCallableUpdate->doUpdate()
#9 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::runUpdate()
#10 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(134): DeferredUpdates::execute()
#11 /srv/mediawiki/php-1.32.0-wmf.12/includes/MediaWiki.php(913): DeferredUpdates::doUpdates()
#12 /srv/mediawiki/php-1.32.0-wmf.12/includes/MediaWiki.php(733): MediaWiki->restInPeace()
#13 (): Closure$MediaWiki::doPostOutputShutdown()
#14 {main}

The above is triggered during compilation of article metadata, but the same warning is also generated when User->saveSettings() is invoked by SpecialNewPagesFeed::execute():

Expectation (writes <= 0) by MediaWiki::restInPeace not met (actual: 3):
query-m: RELEASE SAVEPOINT `wikimedia_rdbms_atomic1` [TRX#848b85]
#0 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/TransactionProfiler.php(219): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated()
#1 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(1243): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion()
#2 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(1143): Wikimedia\Rdbms\Database->doProfiledQuery()
#3 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(3549): Wikimedia\Rdbms\Database->query()
#4 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(3635): Wikimedia\Rdbms\Database->doReleaseSavepoint()
#5 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/rdbms/database/Database.php(3721): Wikimedia\Rdbms\Database->endAtomic()
#6 /srv/mediawiki/php-1.32.0-wmf.12/includes/user/User.php(4219): Wikimedia\Rdbms\Database->doAtomicSection()
#7 /srv/mediawiki/php-1.32.0-wmf.12/extensions/PageTriage/includes/SpecialNewPagesFeed.php(46): User->saveSettings()
#8 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/MWCallableUpdate.php(34): Closure$MediaWiki\Extension\PageTriage\SpecialNewPagesFeed::execute()
#9 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(268): MWCallableUpdate->doUpdate()
#10 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::runUpdate()
#11 /srv/mediawiki/php-1.32.0-wmf.12/includes/deferred/DeferredUpdates.php(134): DeferredUpdates::execute()
#12 /srv/mediawiki/php-1.32.0-wmf.12/includes/MediaWiki.php(913): DeferredUpdates::doUpdates()
#13 /srv/mediawiki/php-1.32.0-wmf.12/includes/MediaWiki.php(733): MediaWiki->restInPeace()
#14 (): Closure$MediaWiki::doPostOutputShutdown()
#15 {main}

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/PageTriagemaster+17 -18Increase accuracy of logging metadata compilation attempts
mediawiki/extensions/PageTriagemaster+101 -155DBPerformance: Master connections and writes via POST not GET
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Jul 16 2018, 2:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2018, 2:22 PM
kostajh updated the task description. (Show Details)Jul 16 2018, 2:27 PM
Aklapper added projects: Wikimedia-production-error, PageTriage.Jul 16 2018, 4:04 PM

+Wikimedia-production-error, +PageTriage

kostajh mentioned this in T154719: PageTriage opens master connection on GET for ArticleMetadata cache misses.Jul 17 2018, 1:59 PM
JTannerWMF moved this task from Inbox to Needs Discussion/Analysis on the Growth-Team board.Jul 18 2018, 6:32 PM
Krinkle renamed this task from Expectation (writes <= 0) by MediaWiki::restInPeace not met (actual: 18): to PageTriage performs unexpected db writes on GET request (TransactionProfiler warning from ArticleCompileProcessor).Jul 25 2018, 7:08 PM
Krinkle triaged this task as Medium priority.
Krinkle added a project: Performance-Team (Radar).
Krinkle moved this task from Untriaged to Since Dec 2018 / 1.33.wmf9 on the Wikimedia-production-error board.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
MMiller_WMF moved this task from Needs Discussion/Analysis to Q1 2018-19 on the Growth-Team board.Aug 7 2018, 6:25 PM
MMiller_WMF added a subscriber: MMiller_WMF.

Putting this in our Q1 column because it is maintenance we can do while we are working on PageTriage as part of T193782 (and it's already halfway done).

MMiller_WMF moved this task from Q1 2018-19 to Upcoming Work on the Growth-Team board.Aug 9 2018, 5:58 PM
JTannerWMF moved this task from Upcoming Work to Current Sprint on the Growth-Team board.Aug 16 2018, 6:10 PM
JTannerWMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
JTannerWMF moved this task from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
SBisson assigned this task to kostajh.Aug 16 2018, 8:04 PM
gerritbot added a subscriber: gerritbot.Aug 19 2018, 10:01 PM

Change 446517 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] DBPerformance: Master connections and writes via POST not GET

https://gerrit.wikimedia.org/r/446517

gerritbot added a project: Patch-For-Review.Aug 19 2018, 10:01 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.Aug 19 2018, 10:04 PM
gerritbot added a comment.Aug 20 2018, 7:34 PM

Change 446517 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] DBPerformance: Master connections and writes via POST not GET

https://gerrit.wikimedia.org/r/446517

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 20 2018, 8:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Aug 20 2018, 8:40 PM
gerritbot added a comment.Aug 21 2018, 1:51 PM

Change 454281 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] Increase accuracy of logging metadata compilation attempts

https://gerrit.wikimedia.org/r/454281

kostajh moved this task from QA to Code Review on the Growth-Team (Current Sprint) board.Aug 21 2018, 1:59 PM
gerritbot added a comment.Aug 21 2018, 3:35 PM

Change 454281 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Increase accuracy of logging metadata compilation attempts

https://gerrit.wikimedia.org/r/454281

JTannerWMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Aug 22 2018, 5:37 PM
Etonkovidova closed this task as Resolved.Aug 22 2018, 10:12 PM
kostajh mentioned this in T202735: Prevent article metadata compilation on rollback actions.Aug 24 2018, 2:11 PM
kostajh mentioned this in T203008: Ensure retrieval and storage of article metadata.Aug 28 2018, 6:32 PM
zeljkofilipin mentioned this in Blog Post: Production Excellence #3: September 2018.Sep 26 2018, 12:17 PM
Krinkle removed a project: Patch-For-Review.Oct 10 2018, 8:19 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL