Add it to the list and make sure there are no regexes along the import path that assume the part after the dash is alphabetic characters rather than numbers.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Map es-419 to es_MX on import, update display name | wikimedia/fundraising/crm | master | +49 -8 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T199680 Fundraising in Latin American Spanish | |||
| Resolved | Ejegg | T199733 Add es-419 as a supported 'preferred language' in Civi |
Event Timeline
Comment Actions
Hi @Pcoombe! I had pulled the patch in to the fundraising/REL_1.31 branch of mediawiki this summer, when it looked like we were going to pull of that upgrade before Big English. Since we're staying on 1.27 for the next few months, I'll see if it's easy to backport that patch. I think a couple files moved between the versions, but the changes in each were pretty small.
Comment Actions
Thanks! Is that T199682? I was actually thinking about the Civi changes on this task. I guess both are required?
Comment Actions
Okay, I tested this myself setting language=es-419 for a card payment, and my preferred language in Civi shows up as es_GB.
I also got redirected to https://donate.wikimedia.org/wiki/Thank_You/es?country=GB instead of https://donate.wikimedia.org/wiki/Thank_You/es-419?country=GB, is that the same issue or should I make a separate task?
Comment Actions
Hey @Pcoombe we had made a quick fix to get through the last campaign but we have a few payments patches that need to go through and we still haven't resolved the support in civi either. What's your priority on this? We could try to make some progress on this in a future sprint.
Comment Actions
Change 666476 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Allow es-419 style language codes in message import
Comment Actions
To get 'es-419' in the preferred_language field we'd either have to convince upstream to lengthen the field or maintain a local hack. @Eileenmcnaughton and I feel like we could accomplish the same thing by mapping es-419 to es_MX for Civi purposes.
Any objections to using es_MX on the backend? We can update the label so it shows up as Spanish (Latin America).
Comment Actions
Change 666476 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Map es-419 to es_MX on import, update display name
Comment Actions
PR to do the same re-labelling upstream https://github.com/civicrm/civicrm-core/pull/19707