Page MenuHomePhabricator
Create Task
Maniphest T199761

Re-add GlobalPreferences to extension-gate
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

GP needs to have its tests to be run with other extensions to avoid other repos breaking it without noticing. We had it but it was reverted in https://gerrit.wikimedia.org/r/#/c/433297/ and discussion about redoing it died. The tests should run only on 1.32+ branches to prevent breaking the older queues.

Details

SubjectRepoBranchLines +/-
Re-add GlobalPreferences to extension-gateintegration/configmaster+2 -0
Customize query in gerrit

Event Timeline

MaxSem created this task.Jul 17 2018, 2:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2018, 2:03 AM
MaxSem added a project: Continuous-Integration-Config.Jul 17 2018, 2:03 AM
• Niharika subscribed.Jul 17 2018, 5:34 PM

@MaxSem Any particular reason this is in the sprint?

MaxSem edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 17 2018, 8:23 PM

Yeah, it's called "habit":P

• Niharika moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jul 17 2018, 10:34 PM
• Niharika set the point value for this task to 2.Jul 17 2018, 11:38 PM
• Niharika moved this task from Needs Discussion to Up Next on the Community-Tech board.
MaxSem updated the task description. (Show Details)Jul 17 2018, 11:40 PM
• Niharika moved this task from Backlog to Wikimedia integration on the MediaWiki-extensions-GlobalPreferences board.Jul 18 2018, 9:24 PM
• Niharika edited projects, added Community-Tech-Sprint; removed Community-Tech.Jul 31 2018, 7:22 PM
• Niharika added a project: Community-Tech.
• Niharika moved this task from Up Next to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Jul 31 2018, 7:24 PM
MaxSem moved this task from Ready to In Development on the Community-Tech-Sprint board.Jul 31 2018, 10:51 PM
gerritbot subscribed.Aug 2 2018, 10:00 PM

Change 450157 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[integration/config@master] Re-add GlobalPreferences to extension-gate

https://gerrit.wikimedia.org/r/450157

gerritbot added a project: Patch-For-Review.Aug 2 2018, 10:00 PM
MaxSem moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Aug 2 2018, 10:11 PM
Mooeypoo assigned this task to MaxSem.Aug 6 2018, 6:03 PM
gerritbot added a comment.Aug 7 2018, 9:34 PM

Change 450157 merged by jenkins-bot:
[integration/config@master] Re-add GlobalPreferences to extension-gate

https://gerrit.wikimedia.org/r/450157

Mooeypoo moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.Aug 7 2018, 10:04 PM
Mooeypoo subscribed.

This was tested by running 'recheck' on this: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalPreferences/+/449375/
(extra job ran and passed)

MaxSem closed this task as Resolved.Aug 7 2018, 10:35 PM

Also core tests pass: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/447036/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL