Page MenuHomePhabricator
Create Task
Maniphest T199788

Don’t report SPARQL errors as violations
Closed, ResolvedPublic
Actions

Description

It doesn’t make sense to report errors with SPARQL queries as constraint violations to users, that’s just confusing. We should log them and then report some inconspicuous status (perhaps TODO?).

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseQualityConstraintswmf/1.32.0-wmf.13+10 -2Report SPARQL errors as TODO, not VIOLATION
mediawiki/extensions/WikibaseQualityConstraintsmaster+10 -2Report SPARQL errors as TODO, not VIOLATION
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 17 2018, 12:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2018, 12:26 PM
matej_suchanek updated the task description. (Show Details)Jul 17 2018, 1:27 PM
Lydia_Pintscher added a project: WMDE-Design.Jul 18 2018, 7:39 PM
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

Do you have a screenshot of how it looks when the error is shown in the violation popup?
Maybe UX can come up with a good wording/way to show this.

Restricted Application added a project: Design. · View Herald TranscriptJul 18 2018, 7:39 PM
Lucas_Werkmeister_WMDE triaged this task as High priority.Jul 19 2018, 10:36 AM

It looks like this:


Since these errors are currently extremely common (notice all the other violation icons in the screenshot), I think we need to move forward with this ASAP.

gerritbot added a subscriber: gerritbot.Jul 19 2018, 10:47 AM

Change 446787 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Report SPARQL errors as TODO, not VIOLATION

https://gerrit.wikimedia.org/r/446787

gerritbot added a project: Patch-For-Review.Jul 19 2018, 10:47 AM
gerritbot added a comment.Jul 19 2018, 12:49 PM

Change 446787 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Report SPARQL errors as TODO, not VIOLATION

https://gerrit.wikimedia.org/r/446787

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 19 2018, 1:00 PM
gerritbot added a comment.Jul 19 2018, 1:28 PM

Change 446813 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.13] Report SPARQL errors as TODO, not VIOLATION

https://gerrit.wikimedia.org/r/446813

Stashbot added a subscriber: Stashbot.Jul 19 2018, 6:27 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-19T18:27:13Z] <ladsgroup@deploy1001> Synchronized php-1.32.0-wmf.13/extensions/WikibaseQualityConstraints: SWAT: [[gerrit:446813|Report SPARQL errors as TODO, not VIOLATION (T199788)]] (duration: 00m 56s)

gerritbot added a comment.Jul 19 2018, 6:37 PM

Change 446813 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.13] Report SPARQL errors as TODO, not VIOLATION

https://gerrit.wikimedia.org/r/446813

Stashbot added a comment.Jul 19 2018, 6:50 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-19T18:50:19Z] <ladsgroup@deploy1001> Synchronized php-1.32.0-wmf.13/extensions/WikibaseQualityConstraints: SWAT: [[gerrit:446813|Report SPARQL errors as TODO, not VIOLATION (T199788)]] (duration: 00m 56s)

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 19 2018, 6:57 PM
Lucas_Werkmeister_WMDE claimed this task.

Deployed. Cached constraint check results with SPARQL errors should be evicted over the next 24 hours.

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 19 2018, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL