It doesn’t make sense to report errors with SPARQL queries as constraint violations to users, that’s just confusing. We should log them and then report some inconspicuous status (perhaps TODO?).
Description
Description
Details
Details
Related Gerrit Patches:
| mediawiki/extensions/WikibaseQualityConstraints : wmf/1.32.0-wmf.13 | Report SPARQL errors as TODO, not VIOLATION |
| mediawiki/extensions/WikibaseQualityConstraints : master | Report SPARQL errors as TODO, not VIOLATION |
Event Timeline
Comment Actions
Do you have a screenshot of how it looks when the error is shown in the violation popup?
Maybe UX can come up with a good wording/way to show this.
Comment Actions
Since these errors are currently extremely common (notice all the other violation icons in the screenshot), I think we need to move forward with this ASAP.
It looks like this:
Since these errors are currently extremely common (notice all the other violation icons in the screenshot), I think we need to move forward with this ASAP.
Comment Actions
Change 446787 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Report SPARQL errors as TODO, not VIOLATION
Comment Actions
Change 446787 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Report SPARQL errors as TODO, not VIOLATION
Comment Actions
Change 446813 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.13] Report SPARQL errors as TODO, not VIOLATION
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-07-19T18:27:13Z] <ladsgroup@deploy1001> Synchronized php-1.32.0-wmf.13/extensions/WikibaseQualityConstraints: SWAT: [[gerrit:446813|Report SPARQL errors as TODO, not VIOLATION (T199788)]] (duration: 00m 56s)
Comment Actions
Change 446813 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.32.0-wmf.13] Report SPARQL errors as TODO, not VIOLATION
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-07-19T18:50:19Z] <ladsgroup@deploy1001> Synchronized php-1.32.0-wmf.13/extensions/WikibaseQualityConstraints: SWAT: [[gerrit:446813|Report SPARQL errors as TODO, not VIOLATION (T199788)]] (duration: 00m 56s)
Comment Actions
Deployed. Cached constraint check results with SPARQL errors should be evicted over the next 24 hours.