Maniphest T199964

[subtask] Missing image or connection issues causes ImageOverlay to display unusable details bar
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	• nray
	Jul 19 2018, 7:37 AM

Description

Steps to Reproduce

Visit a missing image e.g. https://en.m.wikipedia.org/wiki/Barack_Obama#/media/File%3APresident_Barack_Osbama.jpg?
The missing image causes a failed api response.
Notice white bottom bar with "Details" link and "License information" link. Click on links.

This is closely related to T193172, but it was determined that this should be in its own card.

Expected Results

If links are visible, they should behave like links. If they don't, they probably shouldn't be displayed - @alexhollender please advise what we should do here - hide the entire bottom bar?

Actual Results

A white bar at the bottom is shown with a details button and a license information link. Clicking the details button doesn't do anything, and clicking the license information link closes the ImageOverlay. Both of these actions are unexpected.

The data returned from the API is used by ImageOverlay to fill the white bottom bar with a clickable details link and license information. When this data fails to come through, the bottom bar displays unusable links.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ryasmeen	T193172 [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever
		Duplicate		• alexhollender_WMF	T199964 [subtask] Missing image or connection issues causes ImageOverlay to display unusable details bar

Event Timeline

• nray created this task.Jul 19 2018, 7:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2018, 7:37 AM

• nray updated the task description. (Show Details)Jul 19 2018, 7:39 AM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jul 23 2018, 2:33 AM

@nray I'd suggest writing a patch to hide it. We can double confirm with alex before merging. This closely ties in with T193172 so I'm throwing it into the existing sprint. @alexhollender please advise.

Jdlrobson assigned this task to • alexhollender_WMF.Jul 24 2018, 11:01 AM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson moved this task from Needs Prioritization to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.

Moving this back to needs analysis so that we can get some feedback from @alexhollender. Afterwards, let's estimate and pull it back in.

@Jdlrobson @nray

I'd suggest writing a patch to hide it.

Sounds good. Just to clarify:

the bottom bar would start out hidden
we would only show it if/when the image successfully loads
if it doesn't load we should keep it hidden (in addition to showing the error response)

is that correct?

Yup! Shall I merge this into the other task? This doesn't change the estimation imo

👍 (although maybe you're asking @ovasileva)

Jdlrobson closed this task as a duplicate of T193172: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever.Jul 31 2018, 2:33 AM

[subtask] Missing image or connection issues causes ImageOverlay to display unusable details bar Closed, DuplicatePublicActions