I believe the discrepancy comes from the fact that the whisper file for that metric uses average as aggregation method, not sum. Likely because it is a file created a long time ago, before we fixed the issue in modules/role/manifests/graphite/base.pp to have .sum metric files aggregate with sum.

In T199968#4449953, @fgiunchedi wrote:

I believe the discrepancy comes from the fact that the whisper file for that metric uses average as aggregation method, not sum. Likely because it is a file created a long time ago, before we fixed the issue in modules/role/manifests/graphite/base.pp to have .sum metric files aggregate with sum.

Got it, I figured that might be the case but had no way of checking.
Is there a way to alter this for future aggregations of this method?
Is there a way to get a dump of the configs the whisper files use for all? metrics so that issues like this can be seen publicly?
I wonder how many would need fixing.

See Graphite § Troubleshooting on Wikitech for how to check and (if needed) change the xff aggregation logic of an existing metric's whisper file. This would normally be done by an SRE/root on request.

In T199968#4450186, @Addshore wrote:

In T199968#4449953, @fgiunchedi wrote:

I believe the discrepancy comes from the fact that the whisper file for that metric uses average as aggregation method, not sum. Likely because it is a file created a long time ago, before we fixed the issue in modules/role/manifests/graphite/base.pp to have .sum metric files aggregate with sum.

Got it, I figured that might be the case but had no way of checking.
Is there a way to alter this for future aggregations of this method?

Yes, in the sense that newly created files/metrics will be fixed already

Is there a way to get a dump of the configs the whisper files use for all? metrics so that issues like this can be seen publicly?

good question, I don't think the graphite api exposes it so no not out of the box

I wonder how many would need fixing.

I don't know the exact number, but likely any metric created before https://gerrit.wikimedia.org/r/c/operations/puppet/+/235612. Though I can fix mediawiki.edit ones if you want?

In T199968#4455425, @fgiunchedi wrote:

I don't know the exact number, but likely any metric created before https://gerrit.wikimedia.org/r/c/operations/puppet/+/235612. Though I can fix mediawiki.edit ones if you want?

That would be great!

Mentioned in SAL (#wikimedia-operations) [2018-07-27T09:00:12Z] <godog> adjust aggregation to 'sum' for MediaWiki.edit sum metrics - T199968