Maniphest T200026

RepoGroup exceptions due to "false" being passed as a key to MapCacheLRU
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Jul 19 2018, 4:20 PM

Description

PHP Warning: Array key should be either a string or an integer
#0 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/MapCacheLRU.php(201): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.12/includes/libs/ProcessCacheLRU.php(67): MapCacheLRU->hasField(string, boolean, integer)
#2 /srv/mediawiki/php-1.32.0-wmf.12/includes/filerepo/RepoGroup.php(144): ProcessCacheLRU->has(string, boolean, integer)
#3 /srv/mediawiki/php-1.32.0-wmf.12/includes/GlobalFunctions.php(2831): RepoGroup->findFile(Title, array)
#4 /srv/mediawiki/php-1.32.0-wmf.12/includes/Linker.php(746): wfFindFile(Title, array)
#5 /srv/mediawiki/php-1.32.0-wmf.12/includes/specials/SpecialMIMEsearch.php(195): Linker::makeMediaLinkObj(Title, string)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid passing "false" as keys to MapCacheLRU in RepoGroup	mediawiki/core	master	+6 -5
	Avoid passing "false" as keys to MapCacheLRU in RepoGroup	mediawiki/core	wmf/1.32.0-wmf.13	+6 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	zeljkofilipin	T191059 1.32.0-wmf.13 deployment blockers
		Resolved		aaron	T200026 RepoGroup exceptions due to "false" being passed as a key to MapCacheLRU

Event Timeline

aaron created this task.Jul 19 2018, 4:20 PM

Change 446777 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Avoid passing "false" as keys to MapCacheLRU in RepoGroup

https://gerrit.wikimedia.org/r/446777

gerritbot added a project: Patch-For-Review.Jul 19 2018, 4:20 PM

hashar updated the task description. (Show Details)Jul 19 2018, 4:23 PM

Changing priority to UBN since it's blocking the train.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJul 19 2018, 4:33 PM

Removing myself from assigned to since I'm not the one working on this.

Change 447003 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.32.0-wmf.13] Avoid passing "false" as keys to MapCacheLRU in RepoGroup

https://gerrit.wikimedia.org/r/447003

Change 446777 merged by jenkins-bot:
[mediawiki/core@master] Avoid passing "false" as keys to MapCacheLRU in RepoGroup

https://gerrit.wikimedia.org/r/446777

Change 447003 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.13] Avoid passing "false" as keys to MapCacheLRU in RepoGroup

https://gerrit.wikimedia.org/r/447003

Mentioned in SAL (#wikimedia-operations) [2018-07-20T00:31:25Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.13/includes/filerepo/: I58706b5610 and I40f6ad2a3d - T200026 (duration: 00m 56s)

Krinkle closed this task as Resolved.Jul 20 2018, 12:33 AM

Krinkle assigned this task to aaron.

Krinkle added a project: Performance-Team.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 20 2018, 1:00 AM

Liuxinyu970226 unsubscribed.Jul 24 2018, 7:15 AM

greg removed projects: Release, Train Deployments.Dec 17 2018, 11:23 PM

Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptDec 17 2018, 11:23 PM

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:28 PM