Page MenuHomePhabricator

Jenkins shouldn't post failures when "test coverage" is reduced because the number of lines of code are reduced.
Open, Needs TriagePublic

Description

See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/445653/

  1. The code under question was completely covered by tests.
  2. The number of lines were reduced.
  3. The tests succeeded.
  4. Jenkins posted a failure because "code coverage" dropped from 41.31% to 41.25%

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2018, 5:46 PM

T188687: phpunit-patch-coverage logic on when coverage goes down in one file and up for others needs improving is related, but we can probably solve this instance in a simpler way by rounding earlier. For most files we can probably round to nearest integer, and maybe if the file has more than 500 or 1000 lines, then we go to 1-2 decimal points.

For most files we can probably round to nearest integer, and maybe if the file has more than 500 or 1000 lines, then we go to 1-2 decimal points.

I implemented this in https://gitlab.com/legoktm/clover-diff/commit/50e2a145a6748d7dfab4baec850f2332b41b1618

I believe this will be fixed when we do the next rebuild of the Quibble images.