Page MenuHomePhabricator

[intersection] parser tests fail and CI ignore tests
Closed, ResolvedPublic

Description

mediawiki/extensions/intersection has non voting CI job due to multiple failures in the tests.

There were 24 failures:

1) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: basic, single category list, ordered by cat add, desc." ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

2) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: basic, single category list, but ascending" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

3) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: nofollow" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!" rel="nofollow">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2" rel="nofollow">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1" rel="nofollow">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

4) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: Negation with namespace." ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '<ul>\n
-<li><a href="/wiki/Talk:No_Categories" title="Talk:No Categories">Talk:No Categories</a></li></ul>\n
+<li><a href="/wiki/Talk:No_Categories" title="Talk:No Categories">Talk:No Categories</a></li> \n
+<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li></ul>\n

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

5) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: Namespace limited to category." ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

6) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: count and offset combined." ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

7) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: include redirects" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/DPLRedir" class="mw-redirect" title="DPLRedir">DPLRedir</a></li> \n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

8) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: only redirect" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/DPLRedir" class="mw-redirect" title="DPLRedir">DPLRedir</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

9) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: addfirstcategorydate=INVALID" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

10) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: addfirstcategorydate=false" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

11) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=unordered (default)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

12) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=INVALID" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

13) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=ordered" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ol>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ol>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

14) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=none (line breaks)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<p><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a><br /> \n
-<a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a><br /> \n
-<a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a><br />\n
+'<p>No pages meet these criteria.\n

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

15) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=inline (comma list)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<p><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a>, <a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a>, <a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a>\n
+'<p>No pages meet these criteria.\n

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

16) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (complex, no image)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul class="gallery" style="max-width: 791px;_width: 791px;">\n
-	<li class='gallerycaption'>Look at my pretty gallery. http://Britney-Spears</li>\n
-		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
-			<div style="height: 150px;">Yet another DPL test page!</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test p...</a><br />\n
-File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
-			<div style="height: 150px;">DPLTest2</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">DPLTest2</a><br />\n
-File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
-			<div style="height: 150px;">DPLTest1</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a><br />\n
-File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-</ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

17) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (simple, no image)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul class="gallery">\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">Yet another DPL test page!</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test p...</a><br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">DPLTest2</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">DPLTest2</a><br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">DPLTest1</div>\n
-			<div class="gallerytext">\n
-<p><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a><br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-</ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

18) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (complex, with image + bad image)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul class="gallery" style="max-width: 791px;_width: 791px;">\n
+'<ul class="gallery mw-gallery-traditional" style="max-width: 791px;_width: 791px;">\n
 	<li class='gallerycaption'>I love Captions</li>\n
 		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
-			<div style="height: 150px;"><a href="/wiki/File:Bad.jpg" title="File:Bad.jpg">Bad.jpg</a></div>\n
+			<div class="thumb" style="width: 100px;"><div style="margin:25.5px auto;"><a href="/wiki/File:LoremIpsum.djvu" class="image"><img alt="LoremIpsum.djvu" src="http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-70px-LoremIpsum.djvu.jpg" width="70" height="99" srcset="http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-105px-LoremIpsum.djvu.jpg 1.5x, http://example.com/images/thumb/5/5f/LoremIpsum.djvu/page1-140px-LoremIpsum.djvu.jpg 2x" /></a></div></div>\n
 			<div class="gallerytext">\n
-<p><a href="/wiki/File:Bad.jpg" title="File:Bad.jpg">Bad.jpg</a><br />\n
-8 KB<br />\n
+<p><a href="/wiki/File:LoremIpsum.djvu" class="galleryfilename galleryfilename-truncate" title="File:LoremIpsum.djvu">LoremIpsum.djvu</a>\n
+2,480 × 3,508, 5 pages; 3 KB<br />\n
 </p>\n
 			</div>\n
 		</div></li>\n
 		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
-			<div class="thumb" style="width: 100px;"><div style="margin:71px auto;"><a href="/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="70" height="8" /></a></div></div>\n
+			<div class="thumb" style="width: 100px;"><div style="margin:15px auto;"><a href="/wiki/File:Audio.oga" class="image"><img alt="Audio.oga" src="/resources/assets/file-type-icons/fileicon.png" width="120" height="120" /></a></div></div>\n
 			<div class="gallerytext">\n
-<p><a href="/wiki/File:Foobar.jpg" title="File:Foobar.jpg">Foobar.jpg</a><br />\n
-8 KB<br />\n
+<p><a href="/wiki/File:Audio.oga" class="galleryfilename galleryfilename-truncate" title="File:Audio.oga">Audio.oga</a>\n
+</p>\n
+<dl><dt>12 KB<br /></dt></dl>\n
+			</div>\n
+		</div></li>\n
+		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
+			<div class="thumb" style="width: 100px;"><div style="margin:15px auto;"><a href="/wiki/File:Video.ogv" class="image"><img alt="Video.ogv" src="/resources/assets/file-type-icons/fileicon-ogg.png" width="120" height="120" /></a></div></div>\n
+			<div class="gallerytext">\n
+<p><a href="/wiki/File:Video.ogv" class="galleryfilename galleryfilename-truncate" title="File:Video.ogv">Video.ogv</a>\n
+</p>\n
+<dl><dt>12 KB<br /></dt></dl>\n
+			</div>\n
+		</div></li>\n
+		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
+			<div class="thumb" style="height: 150px;"><a href="/wiki/File:Bad.jpg" title="File:Bad.jpg">Bad.jpg</a></div>\n
+			<div class="gallerytext">\n
+<p><a href="/wiki/File:Bad.jpg" class="galleryfilename galleryfilename-truncate" title="File:Bad.jpg">Bad.jpg</a>\n
+320 × 240; 12 KB<br />\n
+</p>\n
+			</div>\n
+		</div></li>\n
+		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
+			<div class="thumb" style="width: 100px;"><div style="margin:48.5px auto;"><a href="/wiki/File:Foobar.svg" class="image"><img alt="Foobar.svg" src="http://example.com/images/thumb/f/ff/Foobar.svg/70px-Foobar.svg.png" width="70" height="53" srcset="http://example.com/images/thumb/f/ff/Foobar.svg/105px-Foobar.svg.png 1.5x, http://example.com/images/thumb/f/ff/Foobar.svg/140px-Foobar.svg.png 2x" /></a></div></div>\n
+			<div class="gallerytext">\n
+<p><a href="/wiki/File:Foobar.svg" class="galleryfilename galleryfilename-truncate" title="File:Foobar.svg">Foobar.svg</a>\n
+240 × 180; 2 KB<br />\n
+</p>\n
+			</div>\n
+		</div></li>\n
+		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
+			<div class="thumb" style="width: 100px;"><div style="margin:40px auto;"><a href="/wiki/File:Thumb.png" class="image"><img alt="Thumb.png" src="http://example.com/images/thumb/e/ea/Thumb.png/70px-Thumb.png" width="70" height="70" srcset="http://example.com/images/thumb/e/ea/Thumb.png/105px-Thumb.png 1.5x, http://example.com/images/e/ea/Thumb.png 2x" /></a></div></div>\n
+			<div class="gallerytext">\n
+<p><a href="/wiki/File:Thumb.png" class="galleryfilename galleryfilename-truncate" title="File:Thumb.png">Thumb.png</a>\n
+135 × 135; 22 KB<br />\n
+</p>\n
+			</div>\n
+		</div></li>\n
+		<li class="gallerybox" style="width: 105px"><div style="width: 105px">\n
+			<div class="thumb" style="width: 100px;"><div style="margin:71px auto;"><a href="/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/thumb/3/3a/Foobar.jpg/70px-Foobar.jpg" width="70" height="8" srcset="http://example.com/images/thumb/3/3a/Foobar.jpg/105px-Foobar.jpg 1.5x, http://example.com/images/thumb/3/3a/Foobar.jpg/140px-Foobar.jpg 2x" /></a></div></div>\n
+			<div class="gallerytext">\n
+<p><a href="/wiki/File:Foobar.jpg" class="galleryfilename galleryfilename-truncate" title="File:Foobar.jpg">Foobar.jpg</a>\n
+1,941 × 220; 8 KB<br />\n

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

19) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: mode=gallery (simple showfilesize, no image)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul class="gallery">\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">Yet another DPL test page!</div>\n
-			<div class="gallerytext">\n
-<p>File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">DPLTest2</div>\n
-			<div class="gallerytext">\n
-<p>File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-		<li class="gallerybox" style="width: 155px"><div style="width: 155px">\n
-			<div style="height: 150px;">DPLTest1</div>\n
-			<div class="gallerytext">\n
-<p>File missing<br />\n
-</p>\n
-			</div>\n
-		</div></li>\n
-</ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

20) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: ordermethod=created (by article id)" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

21) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: ordermethod=length" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

22) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: ordermethod=sortkey" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

23) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: ordermethod=categorysortkey" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

24) ParserIntegrationTest::testParse with data set "DynamicPageList.tests.txt: Magic word in category clause" ('[details omitted]')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<ul>\n
-<li><a href="/wiki/Yet_another_DPL_test_page!" title="Yet another DPL test page!">Yet another DPL test page!</a></li> \n
-<li><a href="/wiki/Talk:DPLTest2" title="Talk:DPLTest2">Talk:DPLTest2</a></li> \n
-<li><a href="/wiki/DPLTest1" title="DPLTest1">DPLTest1</a></li></ul>\n
-'
+'<p>No pages meet these criteria.\n
+</p>'

/workspace/src/tests/phpunit/includes/parser/ParserIntegrationTest.php:53
/workspace/src/maintenance/doMaintenance.php:94

Details

Related Gerrit Patches:
mediawiki/extensions/intersection : REL1_31Fix double prefixing of database table
mediawiki/extensions/intersection : REL1_31Update parser tests expected output
mediawiki/extensions/intersection : masterUpdate parser tests expected output
mediawiki/extensions/intersection : masterFix double prefixing of database table
integration/config : masterMigrate intersection extension to Quibble

Event Timeline

hashar triaged this task as Medium priority.Jul 20 2018, 7:46 AM
hashar created this task.

Change 447038 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/intersection@master] Fix double prefixing of database table

https://gerrit.wikimedia.org/r/447038

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/intersection/+/447038/ fix a lot of tests for me.

Leftover failures are due to changes in the HTML generated by MediaWiki that never get applied to the parser tests examples.

Change 447044 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/intersection@master] Update parser tests expected output

https://gerrit.wikimedia.org/r/447044

hashar claimed this task.Jul 20 2018, 8:43 AM

Change 447038 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Fix double prefixing of database table

https://gerrit.wikimedia.org/r/447038

Change 447044 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Update parser tests expected output

https://gerrit.wikimedia.org/r/447044

Change 447079 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate intersection extension to Quibble

https://gerrit.wikimedia.org/r/447079

hashar closed this task as Resolved.Jul 20 2018, 2:06 PM
hashar added a subscriber: Umherirrender.

Reviewed by @Umherirrender . thank you!

Change 447079 merged by jenkins-bot:
[integration/config@master] Migrate intersection extension to Quibble

https://gerrit.wikimedia.org/r/447079

Change 480152 had a related patch set uploaded (by Paladox; owner: Hashar):
[mediawiki/extensions/intersection@REL1_31] Fix double prefixing of database table

https://gerrit.wikimedia.org/r/480152

Change 480153 had a related patch set uploaded (by Paladox; owner: Hashar):
[mediawiki/extensions/intersection@REL1_31] Update parser tests expected output

https://gerrit.wikimedia.org/r/480153

Change 480153 abandoned by Paladox:
Update parser tests expected output

https://gerrit.wikimedia.org/r/480153

Change 480153 restored by Hashar:
Update parser tests expected output

https://gerrit.wikimedia.org/r/480153

hashar added a comment.EditedDec 19 2018, 2:49 PM

Follow up patches are cherry picks for MW-1.31-release

Change 480153 merged by Umherirrender:
[mediawiki/extensions/intersection@REL1_31] Update parser tests expected output

https://gerrit.wikimedia.org/r/480153

Change 480152 merged by Umherirrender:
[mediawiki/extensions/intersection@REL1_31] Fix double prefixing of database table

https://gerrit.wikimedia.org/r/480152