Maniphest T200079

MassMessageList for RTL is flipped
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	eranroz
	Jul 20 2018, 12:39 PM

Description

How to reproduce:
https://meta.wikimedia.org/wiki/Timeless/Newsletter?uselang=he

bugs:

Titles in Hebrew are left directed
The form of Add pages is flipped
page list dir is LTR

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Directionality handling for MassMessageList pages	mediawiki/extensions/MassMessage	master	+22 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ppelberg	T259951 RTL/LTR display difference between visual and source modes spotted at ckbwiki
		Resolved		matmarex	T200079 MassMessageList for RTL is flipped

Event Timeline

eranroz created this task.Jul 20 2018, 12:39 PM

Restricted Application added a project: I18n. · View Herald TranscriptJul 20 2018, 12:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Adding some potential code projects, otherwise developers won't see this item on their workboard.

Legoktm removed a project: MediaWiki-extensions-Newsletter.Jul 20 2018, 8:23 PM

Gopavasanth triaged this task as Medium priority.Jan 6 2019, 8:58 AM

Meno25 added subscribers: alaa, Meno25.Apr 14 2019, 7:18 PM

matmarex merged tasks: T258004: MassMessage should use the correct page directionality in its lists, T260199: MassMessage list pages are always marked as being LTR.Aug 11 2020, 10:37 PM

matmarex added subscribers: Huji, matmarex.

Change 619589 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MassMessage@master] Directionality handling for MassMessageList pages

https://gerrit.wikimedia.org/r/619589

gerritbot added a project: Patch-For-Review.Aug 11 2020, 11:00 PM

matmarex added a project: Editing-team (Tracking).Aug 11 2020, 11:00 PM

matmarex added a parent task: T259951: RTL/LTR display difference between visual and source modes spotted at ckbwiki.Aug 11 2020, 11:05 PM

Just +2'ed the patch. Feel free to close the task, or wait until we see the effect on WMF wikis and then close it.

Change 619589 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Directionality handling for MassMessageList pages

https://gerrit.wikimedia.org/r/619589

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 17 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 1:10 AM

Thanks!

matmarex mentioned this in T259951: RTL/LTR display difference between visual and source modes spotted at ckbwiki.Aug 17 2020, 9:49 PM