What're you requesting access to?

In T200106#4442205, @Reedy wrote:

What're you requesting access to?

Gerrit +2 code review permissions

That doesn't need ldap access

Have you created an account on wikitech and then logged into gerrit with you?

Yes, I have created a wikitech account (username: nray) and logged into gerrit with it, but I can only +1, not +2.

Which repos are you requiring CR+2 access to?

I believe the following is where I would do the majority of work:

https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/skins/MinervaNeue
https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MobileFrontend
https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Popups

Hi @nray (and welcome!): This makes me wonder what made you think that CR+2 is related to being in the ldap/wmf group. :) If there is some document that you followed it would be great if you could point that out so it can be corrected.
(And https://www.mediawiki.org/wiki/Gerrit/%2B2 does not explain how to potentially get CR+2 rights in Gerrit. Meh.)

In T200106#4442876, @Aklapper wrote:

Hi @nray (and welcome!): This makes me wonder what made you think that CR+2 is related to being in the ldap/wmf group. :) If there is some document that you followed it would be great if you could point that out so it can be corrected.
(And https://www.mediawiki.org/wiki/Gerrit/%2B2 does not explain how to potentially get CR+2 rights in Gerrit. Meh.)

That page does indeed (implicitly) tell Nick to make this request:

For a list of people with +2 rights across mediawiki/*, see https://gerrit.wikimedia.org/r/#/admin/groups/11,members and the wmf LDAP group. There are people outside this list with +2 rights to specific repositories used on Wikimedia sites.

ldap/wmf unfortunately does include some code review privileges but is massively overkill for someone who just wants the code review parts.

I'm not really sure why this has come up on this ticket, but this should be an extremely straightforward process. New WMF employees who are engineers are typically added to the wmf ldap group. For example, T199493.

Yes, ldap/wmf grants +2 in multiple repositories, including mediawiki/*. That has its own ticket, but as it stands, that's the current policy.

I assume that by Monday someone from ops will be able to fullfill this request.

In T200106#4442876, @Aklapper wrote:

Hi @nray (and welcome!): This makes me wonder what made you think that CR+2 is related to being in the ldap/wmf group. :) If there is some document that you followed it would be great if you could point that out so it can be corrected.
(And https://www.mediawiki.org/wiki/Gerrit/%2B2 does not explain how to potentially get CR+2 rights in Gerrit. Meh.)

First, hi and thank you @Aklapper :) I am following a google doc that is (mostly) copied from https://www.mediawiki.org/wiki/Reading/Web/Team/Onboarding. In it, it says:

"Set up your LDAP account (used for Wikitech and Gerrit) following How to become a MediaWiki hacker instructions. Commonly, the username you use is your internet handle (i.e., not a (WMF) username), but you will want to use your @wikimedia.org email address for the email address to receive Gerrit email notifications. Also, request access to the group ldap/wmf, adding your manager to the access request task and emailing your manager with this task's URL to notify about needing approval for this ID if you are a software engineer; this LDAP group gives you more code review approval rights in the system."

I assumed that "code review approval rights" meant the ability to +2. I should clarify that there may be other things that I need that are part of the wmf ldap group. My on-boarding doc also instructs me to request access to these things:

• Apply for access to stat servers and operational logs. Request access to "request logs, including Hive, and event logging", as referenced in the data access guidelines.
• If you will be doing deployment related work (typically, for web engineering and content services), request "deployment access and operational logs access" when following the steps for shell access.
• Apply for beta cluster event logging access

Does the ldap/wmf relate to any of those?

Thanks everyone!

Yes I think ldap/wmf lets you into logstash which will give you access to various logs.

Change 447475 had a related patch set uploaded (by RobH; owner: RobH):
[operations/puppet@production] adding Nicholas Ray to ldap users section

https://gerrit.wikimedia.org/r/447475

Change 447475 merged by RobH:
[operations/puppet@production] adding Nicholas Ray to ldap users section

https://gerrit.wikimedia.org/r/447475

thanks @RobH ! I appreciate your help