Maniphest T200136

Does not work for change a log type drop down when the log type specified by URL / argument @ 1.32.0-wmf.13 (360f7b5)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rxy
	Jul 21 2018, 8:37 PM

Description

Steps to Reproduce: 1.32.0-wmf.13 (rMW360f7b546cb9)
1. Go to https://meta.wikimedia.org/wiki/Special:Log/block
2. Change "Log type drop down menu" from "Block log" to anything (e.g. "All public logs")
3. Click the "Show" button.
Actual Results: Does not work for change a log type drop down when the log type specified by URL / argument @ 1.32.0-wmf.13 (rMW360f7b546cb9)
Expected Results: Must be changed to targeted log type. https://en.wikipedia.org/wiki/Special:Log/block (1.32.0-wmf.12 (eb2e8d4) )

Details

	Subject	Repo	Branch	Lines +/-
	LogEventsList: Use DerivativeContext	mediawiki/core	wmf/1.32.0-wmf.13	+3 -1
	LogEventsList: Use DerivativeContext	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	zeljkofilipin	T191059 1.32.0-wmf.13 deployment blockers
Resolved		None	T193966 Form field should override subpage
Resolved		Jayprakash12345	T200136 Does not work for change a log type drop down when the log type specified by URL / argument @ 1.32.0-wmf.13 (360f7b5)

Event Timeline

Rxy created this task.Jul 21 2018, 8:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2018, 8:37 PM

Rxy added a parent task: T191059: 1.32.0-wmf.13 deployment blockers.Jul 21 2018, 8:38 PM

Confirmed. Regression. This is separate from
T199856, which is also a regression from the SpecialLog refactor from this week.

Krinkle triaged this task as High priority.Jul 21 2018, 8:50 PM

MarcoAurelio added a project: Regression.Jul 22 2018, 11:05 AM

MarcoAurelio subscribed.

Jayprakash12345 added a parent task: T193966: Form field should override subpage.Jul 22 2018, 7:24 PM

This should be fixed by just replacing like

$htmlForm = new HTMLForm( $formDescriptor, $this->getContext() );

$context = new DerivativeContext( $this->getContext() );
$context->setTitle( $this->getPageTitle() ); // Remove subpage
$htmlForm = new HTMLForm( $formDescriptor, $context );

in mediawiki/core/includes/logging/LogEventsList.php

DerivativeContext is important for form submission to override the title.

• Prtksxna mentioned this in T117737: Convert Special:Log to OOUI.Jul 23 2018, 2:41 AM

Getting Fatal Error undefined method LogEventsList::getPageTitle() because getPageTitle() is part of SpecialPage class.

Change 447359 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] LogEventsList: Use DerivativeContext

https://gerrit.wikimedia.org/r/447359

gerritbot added a project: Patch-For-Review.Jul 23 2018, 4:23 AM

In T200136#4444382, @Jayprakash12345 wrote:

Getting Fatal Error undefined method LogEventsList::getPageTitle() because getPageTitle() is part of SpecialPage class.

Yep, LogEventsList gets this using SpecialPage::getTitleFor( 'Log' ) - https://github.com/wikimedia/mediawiki/blob/master/includes/logging/LogEventsList.php#L113

Changing priority to UBN since it's blocking the train.

Friendly reminder: the train is blocked because of this task. (It's not the only blocker at the time I write this.) Any updates?

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJul 23 2018, 3:24 PM

zeljkofilipin awarded a token.Jul 23 2018, 3:25 PM

Someone needs to merge the https://gerrit.wikimedia.org/r/447359. Everything is ready.

Thanks for the patch @Jayprakash12345, I just +2'd it.

I will not be around to SWAT it this time, so someone else will have to do it.

Change 447359 merged by jenkins-bot:
[mediawiki/core@master] LogEventsList: Use DerivativeContext

https://gerrit.wikimedia.org/r/447359

Change 447466 had a related patch set uploaded (by Greg Grossmeier; owner: Prtksxna):
[mediawiki/core@wmf/1.32.0-wmf.13] LogEventsList: Use DerivativeContext

https://gerrit.wikimedia.org/r/447466

In T200136#4445696, @gerritbot wrote:

Change 447466 had a related patch set uploaded (by Greg Grossmeier; owner: Prtksxna):
[mediawiki/core@wmf/1.32.0-wmf.13] LogEventsList: Use DerivativeContext

https://gerrit.wikimedia.org/r/447466

Clarifying question: is this backport sufficient?

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 23 2018, 5:00 PM

Yes, that fixes the issue.

• Prtksxna closed this task as Resolved.Jul 24 2018, 1:41 AM

• Prtksxna assigned this task to Jayprakash12345.

Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptJul 24 2018, 1:41 AM

Liuxinyu970226 unsubscribed.Jul 24 2018, 7:15 AM

Jayprakash12345 merged a task: T200243: Can not change log type.Jul 24 2018, 8:25 AM

Jayprakash12345 added a subscriber: Bugreporter.

Change 447466 abandoned by Zfilipin:
LogEventsList: Use DerivativeContext

Reason:
No wikis at .13 any more

https://gerrit.wikimedia.org/r/447466