Page MenuHomePhabricator

Some "Global Accounts" links on Phabricator profiles are broken due to missing encoding
Closed, ResolvedPublic

Description

When you go to https://phabricator.wikimedia.org/p/daniel/, there's now a "Global Accounts" link. In this case, it's busted, going to https://meta.wikimedia.org/wiki/Special:CentralAuth/Daniel+Kinzler+%28WMDE%29. I'm not sure if this issue is specific to this account or a certain class of accounts.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2018, 12:36 AM
Krenair added a subscriber: Krenair.EditedJul 22 2018, 12:50 AM

It's an encoding thing of + vs. _. It's trying to do Special:CentralAuth/{username} when in fact the encoding appears to be going for the Special:CentralAuth?target={username} type URL instead

It's an encoding thing of + vs. _. It's trying to do Special:CentralAuth/{username} when in fact the encoding appears to be going for the Special:CentralAuth?target={username} type URL instead

That. Should be to &target=$username (urlencoded if possible).

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJul 22 2018, 9:43 AM
Aklapper renamed this task from Some "Global Accounts" links on Phabricator profiles are broken to Some "Global Accounts" links on Phabricator profiles are broken due to missing encoding.Jul 22 2018, 11:57 AM
Framawiki triaged this task as Low priority.Jul 22 2018, 4:55 PM

Patch landed, but needs to be deployed.

MarcoAurelio closed this task as Resolved.Jul 27 2018, 8:24 AM

Deployed and seems to be working as expected. Regards.

Deployed and seems to be working as expected. Regards.

Thank you!