Maniphest T200141

Some "Global Accounts" links on Phabricator profiles are broken due to missing encoding
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• MZMcBride
	Jul 22 2018, 12:36 AM

Description

When you go to https://phabricator.wikimedia.org/p/daniel/, there's now a "Global Accounts" link. In this case, it's busted, going to https://meta.wikimedia.org/wiki/Special:CentralAuth/Daniel+Kinzler+%28WMDE%29. I'm not sure if this issue is specific to this account or a certain class of accounts.

Revisions and Commits

Restricted Differential Revision

Related Objects

Mentioned In: rPHEX0e80ab4ef548: Use `?target=$rawusername` to avoid encoding issues

Event Timeline

• MZMcBride created this task.Jul 22 2018, 12:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2018, 12:36 AM

It's an encoding thing of + vs. _. It's trying to do Special:CentralAuth/{username} when in fact the encoding appears to be going for the Special:CentralAuth?target={username} type URL instead

In T200141#4443437, @Krenair wrote:

It's an encoding thing of + vs. _. It's trying to do Special:CentralAuth/{username} when in fact the encoding appears to be going for the Special:CentralAuth?target={username} type URL instead

That. Should be to &target=$username (urlencoded if possible).

https://meta.wikimedia.org/wiki/Special:CentralAuth?target=Daniel+Kinzler+%28WMDE%29 does work.

MarcoAurelio claimed this task.Jul 22 2018, 9:43 AM

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJul 22 2018, 9:43 AM

MarcoAurelio added a project: Wikimedia-Phabricator-Extensions.Jul 22 2018, 9:43 AM

MarcoAurelio moved this task from unsorted/backlog to working on on the User-MarcoAurelio board.

MarcoAurelio added a revision: Restricted Differential Revision.Jul 22 2018, 10:03 AM

Patch-For-Review : {D1083}.

Aklapper renamed this task from Some "Global Accounts" links on Phabricator profiles are broken to Some "Global Accounts" links on Phabricator profiles are broken due to missing encoding.Jul 22 2018, 11:57 AM

Framawiki removed a project: Phabricator.Jul 22 2018, 4:46 PM

Framawiki triaged this task as Low priority.Jul 22 2018, 4:55 PM

MarcoAurelio moved this task from working on to ready/patched/SWAT on the User-MarcoAurelio board.Jul 22 2018, 10:11 PM

• mmodell awarded a token.Jul 23 2018, 7:23 PM

• mmodell mentioned this in rPHEX0e80ab4ef548: Use `?target=$rawusername` to avoid encoding issues.Jul 23 2018, 7:24 PM

Patch landed, but needs to be deployed.

Deployed and seems to be working as expected. Regards.

MarcoAurelio moved this task from ready/patched/SWAT to cabinet on the User-MarcoAurelio board.Jul 27 2018, 7:09 PM