Page MenuHomePhabricator

WikiEditor toolbar overlaps Notifications flyout in Timeless and Modern skins
Closed, ResolvedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The issue exists only in Timeless skin.

Legoktm renamed this task from WikiEditor toolbar overlaps Notifications flyout to WikiEditor toolbar overlaps Notifications flyout in Timeless skin.Aug 1 2018, 6:49 AM
Evad37 added a subscriber: Evad37.

This is also happening with Modern skin.

echo flyover toolbar overlap in Modern skin.png (922×928 px, 142 KB)

Evad37 renamed this task from WikiEditor toolbar overlaps Notifications flyout in Timeless skin to WikiEditor toolbar overlaps Notifications flyout in Timeless and Modern skins.Aug 1 2018, 7:51 AM

Do we have consistent guidelines anywhere for content vs chrome layering and z-index recommended ranges?

Modern skin will have a transparency issue with VE toolbar too:

Screen Shot 2018-08-02 at 9.23.29 AM.png (334×981 px, 65 KB)

Specifically, that's Echo/Notifications, another extension. Is this echo/toolbar thing happening with everything, or just modern?

Modern skin will have a transparency issue with VE toolbar too:

Screen Shot 2018-08-02 at 9.23.29 AM.png (334×981 px, 65 KB)

Please file a separate ticket for that, on the WE2017/Echo/Modern tags. Its different from this.

Do we have consistent guidelines anywhere for content vs chrome layering and z-index recommended ranges?

Our policy is that we try to avoid z-index in favor of dom order (whenever possible).

Our policy is that we try to avoid z-index in favor of dom order (whenever possible).

But when not?

Change 450152 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Prevent content stuff from overlapping over nav stuff

https://gerrit.wikimedia.org/r/450152

Change 450153 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Modern@master] Prevent content stuff from overlapping over nav stuff

https://gerrit.wikimedia.org/r/450153

Change 450153 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Prevent content stuff from overlapping over nav stuff

https://gerrit.wikimedia.org/r/450153

Isarra claimed this task.

Change 450152 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Prevent content stuff from overlapping over nav stuff

https://gerrit.wikimedia.org/r/450152

@Isarra Thanks for fixing this! I first noticed this as it affected the way my userpage displayed — easy enough fix, nbd — but what's the advantage of having position: relative in #mw_content (already present in Timeless, newly added to Modern) rather than removing it from or adding z-index: 0;to the toolbars, which seem to be the real culprit? Just curious, as it seemed backwards to me.