Page MenuHomePhabricator
Create Task
Maniphest T200155

Error from a broken API request with a generator but the wrong 'g…search' param names the wrong param when erroring
Closed, ResolvedPublic
Actions

Description

If you query generator=wbsearch&gwbsearch=… instead of generator=wbsearch&gwbssearch=… (note the second 's') it errors with "The \"search\" parameter must be set." but it's not actually search that should be set, it's gwbssearch.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+37 -6ApiBase: Use prefixed parameter name for 'missingparam' error
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Jul 22 2018, 11:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2018, 11:21 AM
Anomie claimed this task.Jul 23 2018, 1:07 PM
Anomie added a project: Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).
Anomie moved this task from Backlog to Waiting for Review on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Jul 23 2018, 1:26 PM
gerritbot added a subscriber: gerritbot.Jul 23 2018, 1:26 PM

Change 447412 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiBase: Use prefixed parameter name for 'missingparam' error

https://gerrit.wikimedia.org/r/447412

gerritbot added a project: Patch-For-Review.Jul 23 2018, 1:26 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-API board.Jul 23 2018, 1:26 PM
gerritbot added a comment.Jul 25 2018, 5:29 AM

Change 447412 merged by jenkins-bot:
[mediawiki/core@master] ApiBase: Use prefixed parameter name for 'missingparam' error

https://gerrit.wikimedia.org/r/447412

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 25 2018, 6:00 AM
Anomie closed this task as Resolved.Jul 25 2018, 1:43 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 25 2018, 3:01 PM
Jdforrester-WMF moved this task from Waiting for Review to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.

Thanks for fixing this so promptly.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL