Page MenuHomePhabricator
Create Task
Maniphest T200269

Unable to undelete revision (Fatal error: given Title does not belong to page ID, RevisionStoreRecord)
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Description

  1. Create "Foo" with text "Version 1"
  2. Delete "Foo".
  3. Re-create "Foo" as text "Version 2".
  4. Try to undelete the old revision via Special:Undelete/Foo.

As of wmf.13, fails on both testwiki and test2wiki:

[W1ctUQpAIC0AAHy1RQIAAABG] /w/index.php?title=Special:Undelete&action=submit InvalidArgumentException from line 102 of /srv/mediawiki/php-1.32.0-wmf.13/includes/Storage/RevisionStoreRecord.php: The given Title does not belong to page ID 118665 but actually belongs to 118666

Backtrace:

#0 /srv/mediawiki/php-1.32.0-wmf.13/includes/Storage/RevisionStore.php(587): MediaWiki\Storage\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Storage\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.32.0-wmf.13/includes/Storage/RevisionStore.php(477): MediaWiki\Storage\RevisionStore->insertRevisionInternal(MediaWiki\Storage\RevisionArchiveRecord, Wikimedia\Rdbms\DatabaseMysqli, User, CommentStoreComment, Title, integer, integer)
#2 /srv/mediawiki/php-1.32.0-wmf.13/includes/libs/rdbms/database/Database.php(3731): Closure$MediaWiki\Storage\RevisionStore::insertRevisionOn(Wikimedia\Rdbms\DatabaseMysqli, string)
#3 /srv/mediawiki/php-1.32.0-wmf.13/includes/Storage/RevisionStore.php(479): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure$MediaWiki\Storage\RevisionStore::insertRevisionOn;1196)
#4 /srv/mediawiki/php-1.32.0-wmf.13/includes/page/PageArchive.php(776): MediaWiki\Storage\RevisionStore->insertRevisionOn(MediaWiki\Storage\RevisionArchiveRecord, Wikimedia\Rdbms\DatabaseMysqli)
#5 /srv/mediawiki/php-1.32.0-wmf.13/includes/page/PageArchive.php(506): PageArchive->undeleteRevisions(array, boolean, string)
#6 /srv/mediawiki/php-1.32.0-wmf.13/includes/specials/SpecialUndelete.php(1147): PageArchive->undelete(array, string, array, boolean, User)
#7 /srv/mediawiki/php-1.32.0-wmf.13/includes/specials/SpecialUndelete.php(201): SpecialUndelete->undelete()

Related Objects
Search...

Event Timeline

Krinkle created this task.Jul 24 2018, 1:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2018, 1:47 PM
Krinkle added a parent task: T191059: 1.32.0-wmf.13 deployment blockers.Jul 24 2018, 1:47 PM
Krinkle mentioned this in T199066: PHP error "Revision::ensureTitle: Could not determine title for page " in SpecialMobileContributions.
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
zeljkofilipin triaged this task as Unbreak Now! priority.Jul 24 2018, 2:01 PM
zeljkofilipin added a subscriber: zeljkofilipin.

Changing priority to UBN since it's blocking the train.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJul 24 2018, 2:01 PM
zeljkofilipin awarded a token.Jul 24 2018, 2:01 PM
• Addshore added a subscriber: • Addshore.Jul 24 2018, 2:02 PM
greg added a project: Core-Platform-Team-Old.Jul 24 2018, 3:24 PM
greg added a subscriber: greg.

MCR -> Core Platform Team.

Anomie added a subscriber: Anomie.Jul 24 2018, 3:27 PM

Duplicate of T200072, which already has a patch that someone should review, merge, and backport.

greg closed this task as a duplicate of T200072: MCR broke Undelete action (and made Cognate tests fail) "The given Title does not belong to page ID".Jul 24 2018, 3:34 PM
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJul 24 2018, 3:34 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (Deployment).Jul 27 2018, 10:16 PM
CCicalese_WMF moved this task from Inbox to Done on the Multi-Content-Revisions board.
CCicalese_WMF moved this task from Inbox to Closed on the Core-Platform-Team-Old board.Aug 6 2018, 10:39 PM
jijiki mentioned this in T221763: LinksUpdate fails during page move due to "Title does not belong to page" RevisionStore error from PageImages hook.Apr 24 2019, 11:52 AM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:00 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL