Page MenuHomePhabricator

Increase padding between status bar and tab hearders on non iPhone X devices
Closed, ResolvedPublic

Description

Why are we doing this?

Currently the tab headers feel a bit close to the top of the screen on non iPhone X devices.

Proposed solution

Ensure that there is 30pts of padding between the status bar and the tab headers

Event Timeline

cmadeo triaged this task as Medium priority.Jul 24 2018, 11:44 PM
cmadeo created this task.

@cmadeo is this already fixed? 🤔

iPhone 6s

Simulator ->

Simulator Screen Shot - iPhone 6s - 2018-08-16 at 11.52.16.png (1×750 px, 64 KB)

View debugger ->

Screen Shot 2018-08-16 at 11.48.02 AM.png (643×889 px, 46 KB)

@NHarateh_WMF oh, yep! I think that @JoeWalsh may have fixed this already!

Testing with Wikipedia 6.0.0 (1470) app and iOS 10.3.3 (iPhone 6S). Below are screencaps on the status bar/tab in its current state for the Explore, Places, Saved, History and Search tabs. It looks fine to me.

T200300 Explore.PNG (1×720 px, 437 KB)
T200300 Places.PNG (1×750 px, 215 KB)
T200300 Saved.PNG (1×750 px, 64 KB)
T200300 History.PNG (1×750 px, 50 KB)
T200300 Search.PNG (1×750 px, 49 KB)

JMinor claimed this task.