Page MenuHomePhabricator

Update the Settings header to match other existing tab headers
Closed, ResolvedPublic

Description

Why are we doing this?

We have updated all of the tab headings in the app except for the Settings header. It would be great to make this header more consistent with the rest of the app.

Proposed designs

Event Timeline

cmadeo triaged this task as Medium priority.Jul 24 2018, 11:47 PM
cmadeo created this task.
cmadeo removed a project: Product-QA.

The toolbar is showing at the bottom in this mock... does this have any implications for how sub-views are presented? ie currently when user taps, say, My languages the view comes up from the bottom of the screen covering everything and is closed by an X button...

We can keep it that way, but the X should close back to the Settings screen with the tab bar if the user has the Settings tab turned on instead of the Explore tab.

Also the tab bar will only show in the case above (eg. when the user has turned off Explore and has the settings tab instead)

@cmadeo do we want the large title in both cases - modal (so large title + X close button on the right) and tab or only when Settings is the default tab (so large title, no close button)?

@NHarateh_WMF let’s update the text size on both of that’s not too much of
a hassle

cmadeo added a project: Product-QA.

Thank you so much for working on this! It looks great @NHarateh_WMF!