Page MenuHomePhabricator
Create Task
Maniphest T200310

"Included groups" do not appear in New gerrit UI
Closed, ResolvedPublic
Actions

Description

Old UI:

image.png (595×663 px, 90 KB)

New UI:

image.png (627×1 px, 74 KB)

Looking at old patches I guess this is due to one of the included groups being ldap/wmde ?

Event Timeline

Addshore created this task.Jul 25 2018, 8:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2018, 8:49 AM
Addshore added a project: User-Addshore.Jul 25 2018, 8:49 AM
Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.
Paladox subscribed.Jul 25 2018, 10:09 AM

When I built that, I didn’t think about the rest api could be different heh.

I’ve done fixes on the master branch so it fixes support for the singleusergroup plugin. Not sure if when I fixed that, it also fixes support for ldap groups.

Paladox added a subtask: T200739: Upgrade to Gerrit 2.16.13.Jul 31 2018, 12:04 AM
Paladox moved this task from Bugs & stuff to WMF customizations on the Gerrit board.Sep 6 2018, 9:52 PM
Paladox moved this task from WMF customizations to PolyGerrit on the Gerrit board.
Paladox moved this task from PolyGerrit to Maybe fixed? on the Gerrit board.Oct 8 2018, 4:02 PM
Paladox added a comment.Oct 8 2018, 9:20 PM

Oh, i doin't see ldap/wmf in https://gerrit.wikimedia.org/r/admin/groups/1450,members which is running the fixed version (i back ported the changes).

Paladox added a comment.Oct 8 2018, 9:24 PM

Oh, i doin't see it in the old ui either, @Addshore please confirm weather you see it?

Paladox closed this task as Resolved.Oct 8 2018, 9:32 PM
Paladox claimed this task.

It's all fixed now. Included Groups now show in the UI. After back porting fixes.

Paladox added a comment.Oct 8 2018, 9:35 PM

I've done another fix and back porting it to 2.15. See https://gerrit-review.googlesource.com/c/gerrit/+/199090 .

Jdforrester-WMF closed subtask T200739: Upgrade to Gerrit 2.16.13 as Declined.Jun 4 2020, 8:14 PM
Paladox removed a subtask: T200739: Upgrade to Gerrit 2.16.13.Jun 4 2020, 8:28 PM
hashar moved this task from Maybe fixed? to Bugs & stuff on the Gerrit board.Mar 1 2023, 10:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL