Maniphest T200323

CX2: Section alignment still sluggish and breakable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Petar.petkovic
	Jul 25 2018, 11:32 AM

Description

Section alignment is still sluggish when you add lots of sections to the translation in quick succession.

It breaks from time to time and inserting new section usually fixes everything, but sometimes there aren't any sections to add. This is completely translated page, loaded from in-progress:

This is just one example. Using the tool lately to test the patches revealed lots of broken alignments.

Details

Subject	Repo	Branch	Lines +/-
Alignment: Use minHeight to enforce height instead of height	mediawiki/extensions/ContentTranslation	master	+5 -4
Section alignment: Do a quick test to determine the alignment need	mediawiki/extensions/ContentTranslation	master	+11 -3
For the restored section, give matching id with source section	mediawiki/extensions/ContentTranslation	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T203243: CX2: Coordinates break alignment
T201088: CX2: Alignment broken after adding a template

Event Timeline

• Petar.petkovic created this task.Jul 25 2018, 11:32 AM

• Petar.petkovic updated the task description. (Show Details)Aug 1 2018, 7:05 AM

Pginer-WMF added a project: Language-2018-July-September.Aug 1 2018, 6:10 PM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

• Petar.petkovic mentioned this in T201088: CX2: Alignment broken after adding a template.Aug 2 2018, 7:58 PM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-July-September board.Aug 6 2018, 8:41 AM

• santhosh updated the task description. (Show Details)Aug 8 2018, 10:55 AM

• Petar.petkovic merged a task: T191753: Timeline content: Categories section displayed shifted up in articles with Timeline content.Aug 14 2018, 1:22 PM

• Petar.petkovic added subscribers: Etonkovidova, KartikMistry.

Example from description seems fixed, but again, that is just one example. Alignment still breaks often

While translating en:Hyphen-minus	When draft is loaded (en:Arable_land)

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 24 2018, 8:38 AM

In T200323#4529263, @Petar.petkovic wrote:

Example from description seems fixed, but again, that is just one example. Alignment still breaks often

Have we identified which are the causes for these missalignments, or identifying them is part of the work to be done in the ticket?

In T200323#4533669, @Pginer-WMF wrote:

In T200323#4529263, @Petar.petkovic wrote:

Example from description seems fixed, but again, that is just one example. Alignment still breaks often

Have we identified which are the causes for these missalignments, or identifying them is part of the work to be done in the ticket?

Investigation about the causes is part of the work needed to be done.

• Petar.petkovic mentioned this in T203243: CX2: Coordinates break alignment.Aug 31 2018, 12:32 PM

Change 458354 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Section alignment: Do a quick test to determine the need of alignment

https://gerrit.wikimedia.org/r/458354

gerritbot added a project: Patch-For-Review.Sep 6 2018, 6:26 AM

• santhosh moved this task from Priority backlog to In Review on the Language-2018-July-September board.Sep 6 2018, 6:27 AM

• santhosh claimed this task.Sep 6 2018, 7:56 AM

Change 460206 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] For the restored section, give matching id with source section

https://gerrit.wikimedia.org/r/460206

Change 460206 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] For the restored section, give matching id with source section

https://gerrit.wikimedia.org/r/460206

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 17 2018, 7:00 AM

Change 458354 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Section alignment: Do a quick test to determine the alignment need

https://gerrit.wikimedia.org/r/458354

• Petar.petkovic removed a project: Patch-For-Review.Sep 17 2018, 9:09 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.

Change 461355 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Alignment: Use minHeight to enforce height instead of height

https://gerrit.wikimedia.org/r/461355

gerritbot added a project: Patch-For-Review.Sep 19 2018, 9:18 AM

• Petar.petkovic moved this task from QA to In Review on the Language-2018-July-September board.Sep 19 2018, 10:37 PM

Pginer-WMF edited projects, added Language-2018-Oct-December; removed Language-2018-July-September.Oct 1 2018, 3:57 PM

Pginer-WMF moved this task from Backlog to In Review on the Language-2018-Oct-December board.

Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 4:51 PM

Arrbee moved this task from Backlog to In Review on the Language-Team (Language-2018-October-December) board.

Nikerabbit moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.Oct 17 2018, 7:50 PM

Nikerabbit removed a project: Patch-For-Review.

There is still one unmerged patch linked to this ticket - 461355.
It's currently marked as WIP and @Nikerabbit moved this ticket to QA, so I guess previous work and patches which are already merged are meant to be verified.

Correct.

Checked all examples mentioned in the ticket (including en:Uma Thurman mentioned in unmrged patch https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/461355/) in production (wmf.1) and cx2

Uma Thurman (en->es, ca)
-an (en_>es)
Hyphen-minus
Arable land

The screenshots illustrate that there are no problems with alignment:

Screen Shot 2018-10-26 at 4.06.21 PM.png (947×1 px, 418 KB)

Screen Shot 2018-10-26 at 4.03.31 PM.png (578×1 px, 110 KB)

Uma Turman article - the translated infobox occupies much more of a vertical space than the original one, but all paragraphs get accommodated correctly in terms of a space:

Screen Shot 2018-10-26 at 4.20.33 PM.png (608×1 px, 189 KB)

During testing (on many different articles' layouts), I haven't found yet any cases of misalgnment, so I mark this ticket as Resolved.

Note: There was a recent report - https://www.mediawiki.org/wiki/Topic:Unbemf1hiccy8u8s - that some article (Education in China) was misaligned. However, no details were given - cx version, from which language to which lang etc

• Petar.petkovic moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.Oct 27 2018, 11:04 AM

Change 461355 abandoned by Santhosh:
Alignment: Use minHeight to enforce height instead of height