Page MenuHomePhabricator
Create Task
Maniphest T200372

Special:GlobalRenameProgress Should use OOUI fieldset For Log entries
Closed, ResolvedPublic
Actions

Description

In T193459#4170421, @Volker_E wrote:

Yeah, that should change in a follow-up task at some point.

With Invaild Action

Before:
old 1.png (708×1 px, 94 KB)
and After:
New 1.png (663×1 px, 93 KB)

With Vaild Action

Before:
Old 2.png (663×1 px, 120 KB)
and After:
New 2.png (663×1 px, 120 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CentralAuthmaster+16 -4Special:GlobalRenameProgress: Use OOUI fieldset for log entries
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jayprakash12345 created this task.Jul 25 2018, 9:45 PM
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptJul 25 2018, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jayprakash12345 moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jul 25 2018, 9:45 PM
Jayprakash12345 added a parent task: T104298: Convert CentralAuth special pages to use OOUI.
Jayprakash12345 added a comment.Jul 25 2018, 9:50 PM

Lets work again :)

gerritbot added a subscriber: gerritbot.Jul 25 2018, 9:58 PM

Change 447923 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Special:GlobalRenameProgress Should use OOUI fieldset For Log entries

https://gerrit.wikimedia.org/r/447923

gerritbot added a project: Patch-For-Review.Jul 25 2018, 9:58 PM
Jayprakash12345 updated the task description. (Show Details)Jul 25 2018, 10:06 PM
Jayprakash12345 moved this task from Backlog to Configured on the User-Jayprakash12345 board.
Jayprakash12345 added a comment.Jul 25 2018, 10:32 PM

@Volker_E Should I need to do this with other Log like Move Log?

Before:
old 1.png (439×1 px, 57 KB)
and After:
New 1.png (465×1 px, 58 KB)
Jayprakash12345 awarded a token.Jul 26 2018, 6:44 AM
Volker_E added a comment.Jul 26 2018, 8:29 AM

@Jayprakash12345 Yes, that seems reasonable.

Volker_E added a comment.Aug 10 2018, 11:58 PM

@Jayprakash12345 Please ignore my last comment above, I don't know why I came to that conclusion above?! We should leave other logs like Move log unchanged. It's a result and not something that should be marked up in a fieldset.

gerritbot added a comment.Aug 11 2018, 12:02 AM

Change 447923 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Special:GlobalRenameProgress: Use OOUI fieldset for log entries

https://gerrit.wikimedia.org/r/447923

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 11 2018, 1:00 AM
Jayprakash12345 closed this task as Resolved.Aug 11 2018, 1:42 AM
Jayprakash12345 removed a project: Patch-For-Review.
Jayprakash12345 removed a subscriber: gerritbot.
In T200372#4495851, @Volker_E wrote:

@Jayprakash12345 Please ignore my last comment above, I don't know why I came to that conclusion above?! We should leave other logs like Move log unchanged. It's a result and not something that should be marked up in a fieldset.

Ok, I was thinking to work on that this weekend. Thanks for Informing me :)

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL