Page MenuHomePhabricator

Special:GlobalRenameProgress Should use OOUI fieldset For Log entries
Closed, ResolvedPublic

Assigned To
Authored By
Jayprakash12345
Jul 25 2018, 9:45 PM
Referenced Files
F24120625: old 1.png
Jul 25 2018, 10:32 PM
F24120622: New 1.png
Jul 25 2018, 10:32 PM
F24116663: New 1.png
Jul 25 2018, 10:06 PM
F24116661: New 2.png
Jul 25 2018, 10:06 PM
F24116662: old 1.png
Jul 25 2018, 10:06 PM
F24116660: Old 2.png
Jul 25 2018, 10:06 PM

Description

Yeah, that should change in a follow-up task at some point.

With Invaild Action

Before:
old 1.png (1,440×708 px, 94 KB)
and After:
New 1.png (1,440×663 px, 93 KB)

With Vaild Action

Before:
Old 2.png (1,440×663 px, 120 KB)
and After:
New 2.png (1,440×663 px, 120 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 447923 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CentralAuth@master] Special:GlobalRenameProgress Should use OOUI fieldset For Log entries

https://gerrit.wikimedia.org/r/447923

@Volker_E Should I need to do this with other Log like Move Log?

Before:
old 1.png (1,248×439 px, 57 KB)
and After:
New 1.png (1,250×465 px, 58 KB)

@Jayprakash12345 Please ignore my last comment above, I don't know why I came to that conclusion above?! We should leave other logs like Move log unchanged. It's a result and not something that should be marked up in a fieldset.

Change 447923 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Special:GlobalRenameProgress: Use OOUI fieldset for log entries

https://gerrit.wikimedia.org/r/447923

Jayprakash12345 removed a project: Patch-For-Review.
Jayprakash12345 removed a subscriber: gerritbot.

@Jayprakash12345 Please ignore my last comment above, I don't know why I came to that conclusion above?! We should leave other logs like Move log unchanged. It's a result and not something that should be marked up in a fieldset.

Ok, I was thinking to work on that this weekend. Thanks for Informing me :)