Page MenuHomePhabricator

Template removal removes too much
Closed, ResolvedPublic2 Story Points

Description

From a user report in T198711#4447465:
It seems that visible file info that comes before template set for removal is entirely or almost entirely removed along with this template.

Try to import ( direct link on testwiki )
https://et.wikipedia.org/wiki/Fail:Arujumikas.JPG
with the config
https://www.mediawiki.org/wiki/Extension:FileImporter/Data/et.wikipedia.

The importer removes way more then the given viiCommonsisse.

Event Timeline

Change 448801 had a related patch set uploaded (by WMDE-Fisch; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@wmf/1.32.0-wmf.14] Fix flipped array indexes in template removal code

https://gerrit.wikimedia.org/r/448801

WMDE-Fisch set the point value for this task to 2.
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-07-17 board.

@thiemowmde fixed this on the master branch with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/448565/ the above patch is a backport for the currently on Commons deployed .14 branch.

SWAT Scheduled for today 11 UTC

Change 448801 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@wmf/1.32.0-wmf.14] Fix flipped array indexes in template removal code

https://gerrit.wikimedia.org/r/448801

Mentioned in SAL (#wikimedia-operations) [2018-07-30T12:54:59Z] <zfilipin@deploy1001> Synchronized php-1.32.0-wmf.14/extensions/FileImporter/: SWAT: [[gerrit:448801|Fix flipped array indexes in template removal code (T200406)]] (duration: 00m 57s)

This is deployed now and can be tested with the example given above.

Lea_WMDE closed this task as Resolved.Aug 3 2018, 6:48 AM